Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates for spider #162

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Templates for spider #162

merged 4 commits into from
Jun 11, 2021

Conversation

NohTow
Copy link
Contributor

@NohTow NohTow commented Jun 10, 2021

Templates for the spider dataset.
One major issue was the variation in the writing style of question (some are not really "questions"), so I tried to make it sounds like exercise statements, hope it is good enough.

@srush srush self-assigned this Jun 10, 2021
Copy link
Collaborator

@srush srush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great. But can you also include the reverse entries. "I would describe the SQL statement ... to a new learner as ||| ..."

templates:
4f63f872-06e2-4503-a440-c1908d5cb642: !Template
id: 4f63f872-06e2-4503-a440-c1908d5cb642
jinja: Can you give me the SQL request which respond to "{{question}}" ? ||| {{query}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respond should be "corresponds"

templates/spider/templates.yaml Outdated Show resolved Hide resolved
templates/spider/templates.yaml Outdated Show resolved Hide resolved
@NohTow
Copy link
Contributor Author

NohTow commented Jun 11, 2021

I added your corrections/recommendations and checked the main task box.
I also added the reverse entries, feel free to tell me if something is odd.

@srush srush merged commit 9500a55 into bigscience-workshop:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants