fix: prevent nodeData.onHandlers overwrite#1862
Closed
raphael-p wants to merge 5 commits into
Closed
Conversation
raphael-p
changed the title
raphael-p
changed the title
Collaborator
|
Good catch! |
Contributor
Author
|
closed in favour of #1894, which targets the dev branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this discussion I created: #1861
I started digging into the code a little and realised that
nodeData.onHandlerscan only hold one on-handler at a time since it is wiped every timeaddHxOnEventHandleris called. The fix is to just not do that ifnodeData.onHandlersalready exists.This is fixes the cause of the problem in the linked discussion because when there are multiple on-handlers on an element, only the last one is stored. So then only the last on-handler gets removed when the DOM updates. Every other on-handler just gets re-added without getting removed beforehand.
PS: I made this PR against the master branch, but please shout if it should be dev.