Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing check for has_annotation in somatic_variant_filtration rules #505

Merged
merged 2 commits into from
Apr 29, 2024
Merged

fix: missing check for has_annotation in somatic_variant_filtration rules #505

merged 2 commits into from
Apr 29, 2024

Conversation

tedil
Copy link
Contributor

@tedil tedil commented Apr 29, 2024

Some filter rules in the somatic_variant_filtration workflow were missing checks for has_annotation to construct the correct input/output/log paths. This PR fixes that.

@tedil tedil requested a review from ericblanc20 April 29, 2024 12:12
@github-actions GitHub Actions
Copy link

  • Please format your Python code with black: make black
  • Please format your Snakemake code with snakefmt: make snakefmt
  • Please organize your imports isorts: make isort
  • Please ensure that your code passes flake8: make flake8

You can trigger all lints locally by running make lint

@tedil tedil mentioned this pull request Apr 29, 2024
Merged
@coveralls
Copy link

Coverage Status

coverage: 85.783% (+0.02%) from 85.764%
when pulling d3181b4 on fix-somatic-variant-filtration-annotator-wildcard
into b971088 on main.

@tedil tedil merged commit d7420f7 into main Apr 29, 2024
7 checks passed
@tedil tedil deleted the fix-somatic-variant-filtration-annotator-wildcard branch April 29, 2024 13:59
@tedil tedil mentioned this pull request Jun 28, 2024
Merged
tedil added a commit that referenced this pull request Aug 2, 2024
@tedil
fix: missing check for has_annotation in somatic_variant_filtration…
5f2cbdf 
… rules (#505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericblanc20 ericblanc20 ericblanc20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tedil @coveralls @ericblanc20