From cae16240e9360a24a51487bd365d1eba7f5fc75f Mon Sep 17 00:00:00 2001
From: gromdimon <grom.dima.grom@gmail.com>
Date: Tue, 6 Jun 2023 11:33:24 +0200
Subject: [PATCH] cleanup

---
 docs_manual/source/api_landingzones.rst    |  2 ++
 landingzones/tests/test_permissions.py     | 20 ++++++++++----------
 landingzones/tests/test_permissions_api.py | 14 +++++++-------
 landingzones/views.py                      |  2 +-
 4 files changed, 20 insertions(+), 18 deletions(-)

diff --git a/docs_manual/source/api_landingzones.rst b/docs_manual/source/api_landingzones.rst
index 422f1916..8c826c80 100644
--- a/docs_manual/source/api_landingzones.rst
+++ b/docs_manual/source/api_landingzones.rst
@@ -17,6 +17,8 @@ API Views
 
 .. autoclass:: ZoneCreateAPIView
 
+.. autoclass:: ZoneUpdateAPIView
+
 .. autoclass:: ZoneSubmitDeleteAPIView
 
 .. autoclass:: ZoneSubmitMoveAPIView
diff --git a/landingzones/tests/test_permissions.py b/landingzones/tests/test_permissions.py
index 958e57cf..35ad28ee 100644
--- a/landingzones/tests/test_permissions.py
+++ b/landingzones/tests/test_permissions.py
@@ -209,17 +209,17 @@ def test_zone_update(self):
         good_users = [
             self.superuser,
             self.user_owner_cat,
-            self.user_owner,
             self.user_delegate_cat,
+            self.user_owner,
             self.user_delegate,
             self.user_contributor,
         ]
         bad_users = [
             self.user_contributor_cat,
             self.user_guest_cat,
+            self.user_finder_cat,
             self.user_guest,
             self.user_no_roles,
-            self.user_finder_cat,
             self.anonymous,
         ]
         self.assert_response(url, good_users, 200)
@@ -241,15 +241,15 @@ def test_zone_update_archive(self):
         ]
         bad_users = [
             self.user_owner_cat,
-            self.user_owner,
             self.user_delegate_cat,
-            self.user_delegate,
             self.user_contributor_cat,
-            self.user_contributor,
             self.user_guest_cat,
+            self.user_finder_cat,
+            self.user_owner,
+            self.user_delegate,
+            self.user_contributor,
             self.user_guest,
             self.user_no_roles,
-            self.user_finder_cat,
             self.anonymous,
         ]
         self.assert_response(url, good_users, 200)
@@ -271,15 +271,15 @@ def test_zone_update_disable(self):
         ]
         bad_users = [
             self.user_owner_cat,
-            self.user_owner,
             self.user_delegate_cat,
-            self.user_delegate,
             self.user_contributor_cat,
-            self.user_contributor,
             self.user_guest_cat,
+            self.user_finder_cat,
+            self.user_owner,
+            self.user_delegate,
+            self.user_contributor,
             self.user_guest,
             self.user_no_roles,
-            self.user_finder_cat,
             self.anonymous,
         ]
         self.assert_response(url, good_users, 200)
diff --git a/landingzones/tests/test_permissions_api.py b/landingzones/tests/test_permissions_api.py
index 16c9615c..2e9d1ed6 100644
--- a/landingzones/tests/test_permissions_api.py
+++ b/landingzones/tests/test_permissions_api.py
@@ -164,17 +164,17 @@ def test_update(self):
         good_users = [
             self.superuser,
             self.user_owner_cat,
-            self.user_owner,
             self.user_delegate_cat,
+            self.user_owner,
             self.user_delegate,
         ]
         bad_users = [
             self.user_contributor_cat,
-            self.user_contributor,
             self.user_guest_cat,
+            self.user_finder_cat,
+            self.user_contributor,
             self.user_guest,
             self.user_no_roles,
-            self.user_finder_cat,
         ]
         self.assert_response_api(
             url,
@@ -210,15 +210,15 @@ def test_update_archive(self):
         good_users = [self.superuser]
         bad_users = [
             self.user_owner_cat,
-            self.user_owner,
             self.user_delegate_cat,
-            self.user_delegate,
             self.user_contributor_cat,
-            self.user_contributor,
             self.user_guest_cat,
+            self.user_finder_cat,
+            self.user_owner,
+            self.user_delegate,
+            self.user_contributor,
             self.user_guest,
             self.user_no_roles,
-            self.user_finder_cat,
         ]
         self.assert_response_api(
             url,
diff --git a/landingzones/views.py b/landingzones/views.py
index 7b63b5c1..f138cf1d 100644
--- a/landingzones/views.py
+++ b/landingzones/views.py
@@ -224,11 +224,11 @@ def submit_create(
     def update_zone(self, zone, request=None):
         """
         Handle timeline updating after a LandingZone object has been updated.
+
         :param zone: LandingZone object
         :param form: LandingZoneForm object
         :raise: taskflow.FlowSubmitException if taskflow submit fails
         """
-
         timeline = get_backend_api('timeline_backend')
         user = request.user if request else None