Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n Externalizations tracking #963

Closed
jmromer opened this issue Jul 1, 2019 · 4 comments · Fixed by #1353
Assignees

Comments

@jmromer
Copy link
Member

@jmromer jmromer commented Jul 1, 2019

Files to externalize

  • Excludes admin templates / mailers and API documentation
  • Includes currently unused templates

templates

listing
welcome
  • _root_organization_type_list.html.haml
  • choose_registration.html.haml
  • goodbye.html.haml
  • index.html.haml
  • recovery_stories.html.haml
  • update_browser.html.haml
  • user_home.html.haml
layouts
  • _grid.html.erb
  • _messages.html.haml
  • _messages_u.html.haml
  • _revised_messages.html.haml
  • application.html.haml
  • application_revised.html.haml
  • application_revised_bikehub.html.haml
  • email.html.haml
  • embed_layout.html.haml
  • embed_user_layout.html.haml
  • payments_layout.html.haml
  • reg_embed.html.haml
shared
  • _alert.html.haml
  • _charge.html.erb
  • _content_footer_ad.html.haml
  • _content_skeleton.html.haml
  • _donate_modal.html.haml
  • _edit_bike_skeleton.html.haml
  • _email_bike_box.html.haml
  • _faq.html.haml
  • _footer.html.haml
  • _footer_revised.html.haml
  • _footer_updated.html.haml
  • _form_well_footer_save.html.haml
  • _header.html.haml
  • _header_nav.html.haml
  • _modal.html.haml
  • _organized_skeleton.html.haml
  • _period_select.html.haml
  • _share_this.html.erb
  • _shops_map.html.erb
  • _top_user_nav.html.haml
  • _trash_icon.html.haml
sessions
  • new.html.haml
landing_pages
  • _for_organizations_photo_list.html.haml
  • _next_steps_contact.html.haml
  • _packages_list.html.haml
  • _tweet.html.haml
  • bike_shop_packages.html.haml
  • campus_packages.html.haml
  • cities_packages.html.haml
kaminari
  • _first_page.html.haml
  • _gap.html.haml
  • _last_page.html.haml
  • _next_page.html.haml
  • _page.html.haml
  • _paginator.html.haml
  • _prev_page.html.haml
users
  • _edit_password.html.haml
  • _edit_root.html.haml
  • _edit_sharing.html.haml
  • accept_terms.html.haml
  • accept_vendor_terms.html.haml
  • confirm_error_404.html.haml
  • confirm_error_bad_token.html.haml
  • edit.html.haml
  • globalid.html.haml
  • new.html.haml
  • organization_show.html.haml
  • password_reset.html.haml
  • please_confirm_email.html.haml
  • request_password_reset.html.haml
  • show.html.haml
  • update_password.html.haml
organized
  • ambassador_dashboards/getting_started.html.haml
  • ambassador_dashboards/resources.html.haml
  • ambassador_dashboards/show.html.haml
  • bikes/_list.html.haml
  • bikes/_search.html.haml
  • bikes/incompletes.html.haml
  • bikes/index.html.haml
  • bikes/multi_serial_search.html.haml
  • bikes/new.html.haml
  • bikes/recoveries.html.haml
  • bulk_imports/index.html.haml
  • bulk_imports/new.html.haml
  • bulk_imports/show.html.haml
  • exports/index.html.haml
  • exports/new.html.haml
  • exports/show.html.haml
  • manage/_location_fields.html.haml
  • manage/index.html.haml
  • manage/locations.html.haml
  • messages/index.html.haml
  • messages/show.html.haml
  • stickers/edit.html.haml
  • stickers/index.html.haml
  • users/edit.html.haml
  • users/index.html.haml
  • users/new.html.haml
bikes
  • app/views/bikes/_bike.html.haml
  • app/views/bikes/_bike_org_table.html.haml
  • app/views/bikes/_bike_show_overlays.html.haml
  • app/views/bikes/_bike_table.html.haml
  • app/views/bikes/_bike_u.html.haml
  • app/views/bikes/_edit_primary_menu.html.haml
  • app/views/bikes/_organized_access_panel.html.haml
  • app/views/bikes/_stolen_checklist.html.haml
  • app/views/bikes/_stolen_map.html.erb
  • app/views/bikes/_theft_alerts_table.html.haml
  • app/views/bikes/bike_fields/_revised_colors.html.haml
  • app/views/bikes/bike_fields/_revised_component_fields.html.haml
  • app/views/bikes/bike_fields/_stolen_location.html.haml
  • app/views/bikes/edit_accessories.html.haml
  • app/views/bikes/edit_alert.html.haml
  • app/views/bikes/edit_alert_purchase.html.haml
  • app/views/bikes/edit_alert_purchase_confirmation.html.haml
  • app/views/bikes/edit_bike_details.html.haml
  • app/views/bikes/edit_drivetrain.html.haml
  • app/views/bikes/edit_groups.html.haml
  • app/views/bikes/edit_ownership.html.haml
  • app/views/bikes/edit_photos.html.haml
  • app/views/bikes/edit_publicize.html.haml
  • app/views/bikes/edit_remove.html.haml
  • app/views/bikes/edit_report_recovered.html.haml
  • app/views/bikes/edit_report_stolen.html.haml
  • app/views/bikes/edit_theft_details.html.haml
  • app/views/bikes/index.html.haml
  • app/views/bikes/new.html.haml
  • app/views/bikes/pdf.html.haml
  • app/views/bikes/scanned.html.haml
  • app/views/bikes/show.html.haml
  • app/views/bikes/spokecard.html.haml
errors
  • bad_request.html.erb
  • not_found.html.erb
  • unauthorized.html.erb
  • unprocessable_entity.html.erb
info
  • _terms_text.html.erb
  • _vendor_terms_text.html.erb
  • privacy.html.erb
  • about.html.haml
  • dev_and_design.html.haml
  • image_resources.html.haml
  • lightspeed.html.haml
  • protect_your_bike.html.haml
  • resources.html.haml
  • serials.html.haml
  • support_bike_index.html.haml
  • terms.html.haml
  • vendor_terms.html.haml
  • where.html.haml
organized_mailer
  • finished_registration.html.haml
  • geolocated_message.html.haml
  • organization_invitation.html.haml
  • partial_registration.html.haml
customer_mailer
  • additional_email_confirmation.html.haml
  • confirmation_email.html.haml
  • invoice_email.html.haml
  • invoice_notification_email.html.haml
  • password_reset_email.html.haml
  • recovered_from_link.html.haml
  • stolen_bike_alert_email.html.erb
  • stolen_notification_email.html.haml
  • updated_terms_email.html.haml
  • welcome_email.html.haml
locks
  • _form.html.haml
  • _lock_home.html.haml
  • edit.html.haml
  • new.html.haml
organization_invitations
  • new.html.haml
  • not_available.html.haml
payments
  • _form.html.haml
  • create.html.haml
  • new.html.haml
registrations
  • create.html.haml
  • embed.html.haml
  • new.html.haml
organizations
  • _new_form.html.haml
  • embed.html.haml
  • embed_create_success.html.haml
  • embed_extended.html.haml
  • new.html.haml
public_images
  • _new_form.html.erb
  • _public_image.html.erb
  • show.html.erb
  • edit.html.erb
  • new.html.erb
  • _form.html.haml
  • _revised_public_image.html.haml
  • create.html.haml
misc
  • feedbacks/_form.html.haml
  • feedbacks/index.html.haml
  • manufacturers/index.html.haml
  • memberships/edit.html.haml
  • news/index.html.haml
  • news/show.html.haml
  • recovery_displays/_recovery_display.html.haml
  • stolen/_stickers.html.haml
  • stolen/index.html.haml
  • stolen_notifications/_form.html.haml
  • theft_alert_plans/_theft_alert_plan.html.haml
  • user_embeds/show.html.haml
  • shared/_errors.html.haml

models

listing
  • payment.rb
  • manufacturer.rb
  • bike_code.rb
  • impound_record.rb
  • integration.rb
  • bike.rb
  • theft_alert.rb
  • export.rb
  • organization_message.rb
  • recovery_display.rb
  • user.rb

decorators & helpers

listing
  • bike_decorator.rb
  • lock_decorator.rb
  • paginating_decorator.rb
  • header_tag_helper.rb

controllers

listing
  • application_controller.rb
  • theft_alerts_controller.rb
  • organizations_controller.rb
  • public_images_controller.rb
  • stolen_notifications_controller.rb
  • payments_controller.rb
  • sessions_controller.rb
  • welcome_controller.rb
  • feedbacks_controller.rb
  • integrations_controller.rb
  • locks_controller.rb
  • bikes_controller.rb
  • bike_codes_controller.rb
  • bikes/recovery_controller.rb
  • ownerships_controller.rb
  • user_emails_controller.rb
  • users_controller.rb
  • oauth/applications_controller.rb
  • organized/messages_controller.rb
  • organized/base_controller.rb
  • organized/exports_controller.rb
  • organized/manage_controller.rb
  • organized/users_controller.rb
  • organized/stickers_controller.rb
  • organized/bulk_imports_controller.rb
  • organized/ambassador_task_assignments_controller.rb
  • organized/bikes_controller.rb
  • concerns/sessionable.rb
  • concerns/controller_helpers.rb

misc

  • Stripe donations checkout
  • Stripe promoted alerts checkout
  • React components (some assembly required. see: react-rails-i18n and i18n-js)
@jmromer jmromer self-assigned this Jul 1, 2019
@jmromer

This comment has been minimized.

Copy link
Member Author

@jmromer jmromer commented Jul 1, 2019

The following partials are not referenced directly by any code:
(checking these off as they're removed or determined to be referenced dynamically)

app/views/

listing
  • admin/organizations/custom_layouts/_landing_page.html.haml
  • admin/organizations/custom_layouts/_mail_snippet.html.haml
  • bikes/_bike_org_table.html.haml
  • bikes/_bike_table.html.haml
  • bikes/_bike_u.html.haml
  • documentation/_authentication_info.haml
  • documentation/_extend_authentication_info.markdown
  • documentation/api_v2/_info_footer.markdown
  • documentation/api_v2/_info_header.markdown
  • documentation/api_v3/_info_header.markdown
  • landing_pages/_footer.haml
  • landing_pages/_header_ascend_svg.html.erb
  • landing_pages/_next_steps_contact.html.haml
  • landing_pages/icons/_footer_bike_shops_svg.html.erb
  • landing_pages/icons/_header_ascend_svg.html.erb
  • landing_pages/icons/_header_bike_shops_svg.html.erb
  • landing_pages/icons/_header_cities_svg.html.erb
  • landing_pages/icons/_header_community_groups_svg.html.erb
  • landing_pages/icons/_header_law_enforcement_svg.html.erb
  • landing_pages/icons/_header_school_svg.html.erb
  • layouts/_grid.html.erb
  • layouts/_messages_u.html.haml
  • locks/_lock_home.html.haml
  • public_images/_new_form.html.erb
  • recovery_displays/_recovery_display.html.haml
  • shared/_charge.html.erb
  • shared/_content_skeleton.html.haml
  • shared/_edit_bike_skeleton.html.haml
  • shared/_facebook_pixel.html
  • shared/_organized_skeleton.html.haml
  • shared/_top_user_nav.html.haml
  • stolen/_stickers.html.haml
  • stolen_notifications/_form.html.haml
  • theft_alert_plans/_theft_alert_plan.html.haml
  • users/_edit_password.html.haml
  • users/_edit_root.html.haml
  • users/_edit_sharing.html.haml

The following partials are only referenced directly by the partials above (and are irrelevant because the are just SVGs)

  • landing_pages/icons/_footer_community_groups_svg.html.erb
  • landing_pages/icons/_footer_law_enforcement_svg.html.erb
  • landing_pages/icons/_footer_school_svg.html.erb
  • landing_pages/icons/_footer_shop_svg

Some of the partials above (at any level) might be referenced dynamically by the following lines of code:

app/controllers/bikes_controller.rb:
render "edit_#{@edit_template}".to_sym

app/models/mail_snippet.rb:
partial: "Below \"Finish it\" button, in email \"Partial registration\"",

app/views/landing_pages/ascend.haml:
= render "/landing_pages/icons/header_#{landing_page_target}_svg"

app/views/landing_pages/for_bike_shops.haml:
= render "/landing_pages/icons/header_#{landing_page_target}_svg"

app/views/landing_pages/for_cities.haml:
= render "/landing_pages/icons/header_#{landing_page_target}_svg"

app/views/landing_pages/for_community_groups.haml: =
= render "/landing_pages/icons/header_#{landing_page_target}_svg"

app/views/landing_pages/for_law_enforcement.haml:
= render "/landing_pages/icons/header_#{landing_page_target}_svg"

app/views/landing_pages/for_schools.haml:
= render "/landing_pages/icons/header_#{landing_page_target}_svg"

app/views/layouts/application_revised.html.haml:
= render "/shared/#{current_page_skeleton}"

app/views/users/edit.html.haml:
= render partial: "edit_#{@edit_template}", locals: { f: f }
@sethherr

This comment has been minimized.

Copy link
Member

@sethherr sethherr commented Jul 1, 2019

Quick first look

@sethherr

This comment has been minimized.

Copy link
Member

@sethherr sethherr commented Oct 6, 2019

Just pinging on this - are the checks here accurate? Or is this all done?

@jmromer

This comment has been minimized.

Copy link
Member Author

@jmromer jmromer commented Oct 7, 2019

Thanks for the bump — I added file listings for the remaining categories. Still WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.