Skip to content

/bike_index

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-configurable preferred language, locale detection #944

Merged
merged 9 commits into from Jun 26, 2019

Conversation

@jmromer
Copy link
Member

jmromer commented Jun 25, 2019 •
edited

Provides localization toggling via, in order of precedence:

  1. Query param (settable via the footer UI)
  2. User preference (settable via the user#edit?root form)
  3. The ACCEPT_LANGUAGE header (minimally. settable via browser options)

Adds stub localization files for Spanish (for testing) and Dutch with generated translations of models and attributes

Next steps

  • Externalize template strings to English localization files
  • Set up a translation service (PhraseApp, CrowdIn, Transifex, Locale)

Screenshots

/my_account

Screen Shot 2019-06-26 at 11 24 11 AM

site footer

Screen Shot 2019-06-26 at 11 24 24 AM

via browser preferences

Screen Shot 2019-06-26 at 11 25 11 AM
@jmromer jmromer force-pushed the i18n-1 branch 10 times, most recently from acc1418 to 4af1ccc Jun 25, 2019
@jmromer jmromer mentioned this pull request Jun 26, 2019
Merged
@jmromer jmromer force-pushed the i18n-1 branch from a0616b7 to 5693125 Jun 26, 2019
@jmromer jmromer self-assigned this Jun 26, 2019
@jmromer jmromer marked this pull request as ready for review Jun 26, 2019
@jmromer jmromer force-pushed the i18n-1 branch from 5693125 to 1bcf39e Jun 26, 2019
@jmromer jmromer requested a review from sethherr Jun 26, 2019
@jmromer jmromer force-pushed the i18n-1 branch from 1bcf39e to 813b435 Jun 26, 2019
@jmromer jmromer changed the title Add user-configurable preferred language Add user-configurable preferred language, locale detection Jun 26, 2019
@jmromer jmromer force-pushed the i18n-1 branch 5 times, most recently from 0355273 to 4860d5e Jun 26, 2019
@sethherr
sethherr reviewed Jun 26, 2019
View changes
app/controllers/application_controller.rb Show resolved Hide resolved
@sethherr
sethherr approved these changes Jun 26, 2019
View changes
Copy link
Member

sethherr left a comment

Yay! It begins
jmromer added 5 commits Jun 26, 2019
@jmromer
Add preferred_language to User model
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
94b0a33 
- Adds string `preferred_language` column to user
- Adds validator method to ensure language code corresponds to an available
  localization
@jmromer
Enable updating preferred language via user settings
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
b2e9b23
@jmromer
Add locale form to site footer
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
ccd694f
@jmromer
Set locale from param, user prefs, request header
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
6698eef 
Detect locale from:

1. request param (settable via dropdown in footer)
2. user preferences (settable via users#edit?root)
3. request header (minimally)
@jmromer
Externalize welcome#index hero copy
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
88a1af2
jmromer added 4 commits Jun 26, 2019
@jmromer
Add rails-i18n, i18n_generators
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
a63f8de
@jmromer
Add generated translation entries
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
8ae6290
@jmromer
Only set locale if feature is enabled
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
618a188
@jmromer
Add todo
Verified
This commit was signed with a verified signature.
jmromer Jake Romer
GPG key ID: 8E627277FC2F725F Learn about signing commits
Loading status checks…
e2b85cb
@jmromer jmromer force-pushed the i18n-1 branch from 58d6626 to e2b85cb Jun 26, 2019
@jmromer jmromer merged commit 8b858a6 into master Jun 26, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
@jmromer jmromer deleted the i18n-1 branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethherr sethherr

Assignees

@jmromer jmromer

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jmromer @sethherr
You can’t perform that action at this time.