Add user-configurable preferred language, locale detection #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmromer
force-pushed
the
i18n-1
branch
10 times, most recently
from
acc1418
to
4af1ccc
Compare
jmromer
changed the title
jmromer
force-pushed
the
i18n-1
branch
5 times, most recently
from
0355273
to
4860d5e
Compare
sethherr
reviewed
Jun 26, 2019
added 5 commits
Jun 26, 2019
- Adds string `preferred_language` column to user - Adds validator method to ensure language code corresponds to an available localization
Detect locale from: 1. request param (settable via dropdown in footer) 2. user preferences (settable via users#edit?root) 3. request header (minimally)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Provides localization toggling via, in order of precedence:
ACCEPT_LANGUAGEheader (minimally. settable via browser options)Adds stub localization files for Spanish (for testing) and Dutch with generated translations of models and attributes
Next steps
Screenshots
/my_accountsite footer
via browser preferences