Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorbet #1

Merged
merged 4 commits into from Jun 24, 2019

Conversation

Projects
None yet
1 participant
@bilbof
Copy link
Owner

commented Jun 21, 2019

Adds static type checking (with https://github.com/sorbet/sorbet) to finder-frontend, a rails application that serves search pages on GOV.UK.

Bill Franklin added some commits Jun 20, 2019

Bill Franklin
Run sorbet init
This runs 'sorbet init', which autogenerates many
changes, including:

- adding '# typed: <type check status>' to the top of all files
- adding a sorbet/ directory, which contains RBI files and a sorbet config file

Running 'sorbet tc' at this stage passes as there
are no errors related to syntax, constant resolution or
issues with sigs. Good stuff!

The next step will be to introduce static checks.
Bill Franklin
Make CacheableRegistry typed
Kernel is included since we call 'raise' here and
we must be explicit in where this comes from.
Bill Franklin
Make CacheableRegistry strictly typed
This changes the typed mode for this module from
'true' to 'strict', which requires annotations
for methods and variables.

@bilbof bilbof merged commit 923b1f7 into master Jun 24, 2019

@bilbof bilbof deleted the sorbet branch Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.