Skip to content

chore(security): bump upload-artifact v4.6.2 -> v7.0.1 + add OpenSSF Scorecard#14

Merged
bilbospocketses merged 1 commit into
masterfrom
chore/security-followup-upload-artifact-scorecard
May 19, 2026
Merged

chore(security): bump upload-artifact v4.6.2 -> v7.0.1 + add OpenSSF Scorecard#14
bilbospocketses merged 1 commit into
masterfrom
chore/security-followup-upload-artifact-scorecard

Conversation

@bilbospocketses
Copy link
Copy Markdown
Owner

Two security-followup items from a cross-repo posture audit vs. ws-scrcpy-web and oao.

upload-artifact bump (ci.yml 1 site, release.yml 3 sites)

OpenSSF Scorecard workflow (new .github/workflows/scorecard.yml)

  • Triggers: branch_protection_rule (catches master-ruleset regressions), weekly cron Monday 09:00 ET (matches Dependabot + CodeQL cadence), push to master.
  • SARIF uploads to Security tab (security-events: write) so findings sit next to CodeQL. Published to api.securityscorecards.dev via OIDC (id-token: write) for the public scorecard.dev/viewer/?uri=github.com/bilbospocketses/control-menu page.
  • All actions SHA-pinned with precise version comments. Workflow-level permissions: read-all with narrower per-job grants.
  • Allowlist: ossf/scorecard-action@* added to repo-level patterns_allowed (was just softprops/action-gh-release@*). github/codeql-action/upload-sarif is github-owned, covered by github_owned_allowed. Pre-merge — already applied via gh api PUT.
  • Mostly informational — CM already passes the bulk of Scorecard's checks via the Tier 1-5 hardening pass. Ongoing value is drift detection.

Test plan

  • CI build-and-test passes (uses bumped upload-artifact step for test-results)
  • Post-merge: scorecard.yml runs on the merge commit's push-to-master and uploads SARIF
  • Post-merge: next tag push exercises release.yml's 3 upload-artifact sites on v7.0.1

…Scorecard

upload-artifact bump (ci.yml 1 site, release.yml 3 sites)
- SHA ea165f8d -> 043fb46d. Closes the Node 20 deprecation banner that has
  been firing on every workflow run since GitHub's 2026-06-02 force_node24
  cutover was announced; v7.x runs on Node 24.
- Root cause of why this drifted while every other action stayed current: the
  prior pin had a bare `# v4` comment (just the major). Dependabot uses the
  trailing comment as the version anchor and treats bare-major as a "track v4
  line" range pin -- so it never proposed a major-bump PR even though v5, v6,
  and v7 had all shipped. The 5 other actions in this repo all had precise
  `# v<x>.<y>.<z>` comments at SHA-pin time and got Dependabot bumps in PRs
  #1, #2, #3, #4, #5 on 2026-05-18. upload-artifact was silently skipped.
- New pin uses precise `# v7.0.1` comment so future bumps surface normally.
- v5 dropped immutable artifact names (same `name:` rejected twice per run).
  Verified safe: this repo uses 4 distinct names across the 4 upload sites
  (test-results, unsigned-windows-exes, unsigned-windows-msi, windows-final).

OpenSSF Scorecard workflow (new .github/workflows/scorecard.yml)
- Triggers: branch_protection_rule (catches master-ruleset regressions),
  weekly cron Monday 09:00 ET (matches Dependabot + CodeQL cadence), push
  to master.
- SARIF uploads to Security tab (security-events: write) so findings sit
  next to CodeQL. Published to api.securityscorecards.dev via OIDC for the
  public scorecard.dev viewer page.
- All actions SHA-pinned with precise version comments. Workflow-level
  `permissions: read-all` with narrower per-job grants.
- Allowlist: `ossf/scorecard-action@*` added to repo-level
  patterns_allowed (was just `softprops/action-gh-release@*`).
  `github/codeql-action/upload-sarif` covered by github_owned_allowed.
- Mostly informational -- CM already passes the bulk of Scorecard's
  checks via the Tier 1-5 hardening pass. Ongoing value is drift
  detection (a future workflow regressing on Token-Permissions or
  Pinned-Dependencies would surface a score delta).
@bilbospocketses bilbospocketses merged commit 33e291e into master May 19, 2026
5 checks passed
@bilbospocketses bilbospocketses deleted the chore/security-followup-upload-artifact-scorecard branch May 19, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant