chore(security): tighten rulesets (rebase-drop + CodeQL/Scorecard gating + tag-signing) + scorecard PR trigger#17
Merged
bilbospocketses merged 1 commit intoMay 19, 2026
Conversation
…ing + tag-signing) + scorecard PR trigger
Cross-repo Tier B security parity sweep. svgedit, OAO, ws-scrcpy-web all
landed equivalent ruleset tightening in parallel sessions today; this PR
brings CM to parity plus a CM-specific Scorecard-as-required-check extra.
Ruleset changes (API-only, already applied pre-PR via gh api PUT):
- Branch ruleset 16554261:
- pull_request.allowed_merge_methods ["merge","squash","rebase"] -> ["squash","merge"]
- required_status_checks: added Analyze (csharp), Analyze (javascript-typescript),
Analyze (actions) (CodeQL App, integration_id 15368) + Scorecard analysis
- Tag ruleset 16554225: added required_signatures
- Repo-level: allow_rebase_merge true -> false (UI cleanup; ruleset is the binding gate)
scorecard.yml companion changes (in this PR):
- Added `pull_request: branches: [master]` trigger so the new required check
actually reports on PRs. Without it, every PR would block forever waiting
for Scorecard analysis that never runs.
- Gated `publish_results: ${{ github.event_name == 'push' }}` — PR runs
publish a branch-HEAD SHA not on master, triggering the same OpenSSF
webapp "imposter commit" 400 we hit in PR #15 (different cause, same
SHA-not-on-commit-graph failure mode).
Deferrals documented in CHANGELOG:
- Items #6 + #7 (secret-scanning non_provider_patterns + validity_checks)
require GHAS license; PATCH calls silently no-op on free tier (confirmed
empirically on svgedit). Deferred indefinitely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-repo Tier B security parity sweep. svgedit + OAO + ws-scrcpy-web all landed equivalent ruleset tightening in parallel sessions today; this PR brings CM to parity, plus a CM-specific Scorecard-as-required-check extra. Relayed from another session — verified state-deltas pre-apply.
Ruleset changes (already applied via gh api PUT before this PR)
Branch ruleset 16554261
Tag ruleset 16554225
Repo-level
scorecard.yml companion changes (in this PR)
Deferrals
SHA-pin audit (clean, no fixes needed)
All 8 distinct SHA pins across 17 occurrences in ci.yml / release.yml / scorecard.yml audited against the two new SOP memories shipped this session ([[dependabot-precise-version-comment]] + [[action-sha-pin-commit-not-tag-object]]). Every comment is precise (`# vX.Y.Z`); every SHA dereferences to `type: commit`. The two annotated-tag offenders (`ossf/scorecard-action`, `github/codeql-action`) were already remediated in PRs #15 + #16. No further pin-hygiene work needed.
Test plan