Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitter desktop #152

Closed
andia89 opened this issue May 10, 2016 · 6 comments
Closed

Gitter desktop #152

andia89 opened this issue May 10, 2016 · 6 comments

Comments

@andia89
Copy link
Collaborator

andia89 commented May 10, 2016

Gitter still uses a hardcoded icon. It is build using chrome as base, as far as I understand, so maybe the icon is located in nw.pak (haven't found it though)

@andia89 andia89 added the bug label May 10, 2016
@bilelmoussaoui
Copy link
Owner

I didn't found it neither, i think that the icon is hardcoded in the binary file? don't know if it's possible..

@andia89
Copy link
Collaborator Author

andia89 commented May 10, 2016

I might be able to filter it out from the binary and replace it. Might be worth a try...

@bilelmoussaoui
Copy link
Owner

The icon names are here https://github.com/gitterHQ/desktop/tree/master/nwapp/img. I still don't know if they're hardcoded or not;

@andia89
Copy link
Collaborator Author

andia89 commented May 11, 2016

As far as I can see, the png is not stored in the binary, extracting the png files that are stored directly in the binary only gives different pngs...

@bilelmoussaoui
Copy link
Owner

Gitter will release a new version of their app soon, lets wait and see if
they will move to Electron?
Le 11 mai 2016 20:32, "Andreas Angerer" notifications@github.com a écrit :

As far as I can see, the png is not stored in the binary, extracting the
png files that are stored directly in the binary only gives different
pngs...


You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#152 (comment)

@bilelmoussaoui bilelmoussaoui modified the milestone: v4.0 Jul 17, 2016
@bilelmoussaoui bilelmoussaoui modified the milestones: v4.0, v3.8.1 May 21, 2017
@bilelmoussaoui
Copy link
Owner

It's now possible to fix nwjs apps.
The user must add a new config in the config file with the key nwjs-bin which contains the absolute path to the nwjs sdk that must be downloaded and extracted somewhere.
So happy to see this fixed after a year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants