Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing failed for electron icons #171

Closed
andia89 opened this issue Aug 11, 2016 · 7 comments
Closed

Fixing failed for electron icons #171

andia89 opened this issue Aug 11, 2016 · 7 comments
Labels

Comments

@andia89
Copy link
Collaborator

andia89 commented Aug 11, 2016

fixing failed with error:
    Traceback (most recent call last):
      File "/home/andreas/Diverses/Hardcode-Tray/database/scripts/electron", line 56, in <module>
        fileinfo = getFromDict(files, keys)
      File "/home/andreas/Diverses/Hardcode-Tray/database/scripts/electron", line 14, in getFromDict
        return reduce(lambda d, k: d[k], mapList, dataDict)
      File "/home/andreas/Diverses/Hardcode-Tray/database/scripts/electron", line 14, in <lambda>
        return reduce(lambda d, k: d[k], mapList, dataDict)
    KeyError: 'tray-skypeTemplate@2x.png'

this happened when trying to fix skypeforlinux

@bilelmoussaoui
Copy link
Owner

Maybe the keys changed on the latest version of skype? We need to check if d[k] exists first to avoid this error

@bilelmoussaoui bilelmoussaoui modified the milestone: v4.0 Aug 14, 2016
@bilelmoussaoui
Copy link
Owner

Can you try after removing the skypeTemplate icon line? I think this icon is no more needed

@andia89
Copy link
Collaborator Author

andia89 commented Sep 5, 2016

All good after removing the line :)

@bilelmoussaoui
Copy link
Owner

I guess we can remove the line. But it might be used for older versions of
skypeforlinux. Maybe adding a verification to check if the key exists
before? This way we keep supporting for old versions of electron
applications

Le 5 sept. 2016 13:15, "Andreas Angerer" notifications@github.com a
écrit :

All good after removing the line :)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#171 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHTlxVZ_tjGihPoVry8xR2hA8Q-pXdPYks5qm_nogaJpZM4Jh5Tr
.

@andia89
Copy link
Collaborator Author

andia89 commented Sep 5, 2016

I can do that

@andia89
Copy link
Collaborator Author

andia89 commented Sep 5, 2016

Fixd

@andia89 andia89 closed this as completed Sep 5, 2016
@bilelmoussaoui
Copy link
Owner

That would be great, i don't have my laptop anymore so i cant contribute to
any project at the moment :/

Le 5 sept. 2016 13:21, "Andreas Angerer" notifications@github.com a
écrit :

I can do that


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#171 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHTlxZCLw3k4g3ac_CyCYjgx_YajxzDkks5qm_tKgaJpZM4Jh5Tr
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants