@2x icons

[andia89]

We should somehow implement, that if a icon name contains @2x it should be doubled in size (if it is a png at least). This should enable us to have HiDPi support

[bilelmoussaoui]

This was already implemented in order to fix Caprine icons #169
Edit: if you have any issue with that, you can reopen this one

[andia89]

Ah I see, but this is not a good fix, isn't it?
Instead of looking for a 22px icon and double it in size, the script is now looking for a 44px sized icon which arguably does not exist. The theme_lookup funtion should still looking for a 22px icon, and after converting it to png (no further action needed for svg icons) it should double its size

[bilelmoussaoui]

Ah i didn't think of that! Do you have any idea how to double an svg icon on size? I thnik we can only use Inksape for an easy solution..

[andia89]

How did you do it for numix-core? There I guess you have to do multiple sizes, right?

[bilelmoussaoui]

Ah completly forgot that i have already did that :P I will implement the same code here 👍

[andia89]

We have to think about how to handle all the script (electron) things though, where there are also potentially @2x icons.

[bilelmoussaoui]

I will save the icons on /tmp folder and i can give the icon path to electron script which only have to handle the case where the icon is a path, what do you think?

[andia89]

Hmm, I really like the current situation where everthing is written into ram instead of saving it to hard disc. We can keep the binary blob of the png in working memory, just like we do right now for electron scripts...

[andia89]

png_io = BytesIO()
        img.write_to_png(png_io)
        with open(outfile, 'wb') as fout:
            fout.write(png_io.getvalue())
        svg.close()
        png_io.close()
        img.finish()

png_io should be the correct icon right? No need to write a temporary icon anywhere imo

[bilelmoussaoui]

Ah yeah! i will implement it that way 👍

[andia89]

maybe we can rewrite the svgtopng script to accept a size argument?

[bilelmoussaoui]

Yeah :) it's the easiest solution we can implement !

[andia89]

Top 👍

[bilelmoussaoui]

Done! Will push the new code in few minutes




The quality is quite nice 👍

[bilelmoussaoui]

Fixed