Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve replace colors #302

Closed
bilelmoussaoui opened this issue Jan 19, 2017 · 0 comments
Closed

Improve replace colors #302

bilelmoussaoui opened this issue Jan 19, 2017 · 0 comments
Assignees

Comments

@bilelmoussaoui
Copy link
Owner

For now, you should give the exact hex colors in order to replace them; Because we use the simply replace method. We should move to using Regex instead.
Should be done here https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/modules/utils.py#L318

also if the user uses --replace-colors "#fff #000" and there's only #ffffff defined in the SVG file, it will break the things, so we should always use 6 hexadecimal instead of 3!

@bilelmoussaoui bilelmoussaoui self-assigned this Jan 19, 2017
bilelmoussaoui added a commit that referenced this issue Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant