Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid CSV #5

Closed
Foggalong opened this issue Apr 17, 2015 · 6 comments
Closed

Invalid CSV #5

Foggalong opened this issue Apr 17, 2015 · 6 comments

Comments

@Foggalong
Copy link
Contributor

The db.csv file isn't valid. Github provides a nice feature for debugging though so it shouldn't be too hard to fix :)

@bilelmoussaoui
Copy link
Owner

Well, i knew about this but i have no idea(at the moment) how to fix this. The github can't read a csv file with more than 8 rows by line (i guess). But the python module does.
To explain why i chose that, every line is for a specific application. For example touchpad-indicator the line in db.csv is like this
The app name, the hardcoded directory, icon1,icon2,icon3.. Iconx
So some apps might have too many icons => too many rows in a line.
I was going to use json so i can have only three rows and the third one is for icons but it won't be that easy for users to add other apps.
That being said, but i'm open for any ideas.

Thank you for reporting this !

@Foggalong
Copy link
Contributor Author

Ah, I think I see how it works now. Yeah, I'm not sure how you'd go about fixing that because as you say every line would be different :(

You can do blank "cells" in CSV by just doing ,, but I have no idea if that would help or make things more complicated.

@bilelmoussaoui
Copy link
Owner

I thought about putting every icon in a line but that will make the code a little bit complicated. I will think about this ;)

Le 17 avr. 2015 à 12:27, Joshua Fogg notifications@github.com a écrit :

Ah, I think I see how it works now. Yeah, I'm not sure how you'd go about fixing that because as you say every line would be different :(

You can do blank "cells" in CSV by just doing ,, but I have no idea if that would help or make things more complicated.


Reply to this email directly or view it on GitHub.

@palob
Copy link

palob commented Apr 18, 2015

How does it look in a text editor? Maybe there is something wrong with the newline characters?

@bilelmoussaoui
Copy link
Owner

First, thank your comment. But i don't think its the newline character as the csv module in python dosent show any issues/bugs.

The problem here is that db.csv is not a valid file for github. And i don't have any idea how to fix this. I thought about putting every icon in a line like this :
App-name1,hardcod directory, icon1
App-name1,hardcod directory, icon2
..
..
App-name2,hardcod directory, icon1
..
..

That will fix this and the db.csv will be a valid file for github. But that will not be the nicest way to fix it !

Le 19 avr. 2015 à 00:11, palob notifications@github.com a écrit :

How does it look in a text editor? Maybe there is something wrong with the newline characters?


Reply to this email directly or view it on GitHub.

@bilelmoussaoui
Copy link
Owner

This is fixed now 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants