support cygwin and ensure shared libs are on more verbosely #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilke
requested changes
Feb 28, 2017
conanfile.py
Outdated
| @@ -10,10 +10,10 @@ class VTKConan(ConanFile): | |||
| SHORT_VERSION = short_version | |||
| generators = "cmake" | |||
| settings = "os", "compiler", "build_type", "arch" | |||
| options = {"shared": [True, False], "qt": [True, False]} | |||
| default_options = "shared=False", "qt=False" | |||
| options = {"shared": [True, False], "qt": [True, False],"cygwin_msvc": [True, False],"linux_use_sudo": [True, False]} | |||
There was a problem hiding this comment.
Please separate new options by a whitespace, or better by splitting this long line into multiple lines.
conanfile.py
Outdated
| exports = ["CMakeLists.txt", "FindVTK.cmake"] | ||
| url="http://github.com/bilke/conan-vtk" | ||
| url="http://github.com/pkarasev3/conan-vtk" |
| CMAKE_OPTIONALS = "" | ||
| BUILD_OPTIONALS = "" | ||
| if self.options.shared == False: | ||
| CMAKE_OPTIONALS += " -DBUILD_SHARED_LIBS=OFF" | ||
| if self.options.shared == True: |
Turn off Group_StandAlone build and remove unnecessary libs
bilke
force-pushed
the
release/7.1.0
branch
4 times, most recently
from
2dc4e0b
to
b5f9a13
Compare
bilke
force-pushed
the
release/7.1.0
branch
2 times, most recently
from
8922839
to
b322439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let me know if this change works in principle ... (modulo the url path I presume)