New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis-ci for hacktoberfest #31

Merged
merged 4 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@dangarthwaite
Copy link
Contributor

dangarthwaite commented Oct 4, 2018

I first added circleci, then travis-ci. Both are having problems because of the GO 1.11 GOMODULES changes. Tools still expect the source code to be in $GOPATH.

The present solution in both CI/CD's is to preappend commands with GO111MODULES=on. This should go away in Go >= 1.12

Also - it is failing on my side because it looks for billglover/bbot and not dangarthwaite/bbot. I'm making this pull request because that might be fixed once merged.

@billglover

This comment has been minimized.

Copy link
Owner

billglover commented Oct 4, 2018

Many thanks @dangarthwaite, I appreciate modules is still experimental at the moment. Working off a fork can be particularly frustrating for the reason you articulate.

I'm going to merge this as-is and enable Travis CI on the repo. I'll raise new issues for any problems that arise as this can be a bit fiddly to get up and running on the first shot.

Appreciate the help.

@billglover billglover merged commit e3125bd into billglover:master Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment