Skip to content

Bill Graham
billonahill

  • Twitter
  • Joined on Sep 9, 2008

Organizations

@twitter
May 27, 2016
billonahill commented on pull request twitter/heron#818
@billonahill

This patch is not yet ready to be merged. It needs more testing, since no all files are being checked it seems.

May 27, 2016
@billonahill
May 27, 2016
@billonahill
  • @billonahill 938f492
    moving checkstyle_all to root dir
May 27, 2016
@billonahill
May 27, 2016
billonahill opened pull request twitter/heron#818
@billonahill
Change checkstyles to happen once before build on all files
1 commit with 21 additions and 3 deletions
May 26, 2016
billonahill commented on issue twitter/heron#808
@billonahill

That's really strange. the _pex.py file can't another instance of find itself. Can you try changing Trace.shsout_log to return True and see what yo…

May 26, 2016
billonahill commented on issue twitter/heron#799
@billonahill

Thanks @nlu90 that's such a good hack and I think that will work for me. To expand on item 2 above, the idea is that for the CI build only, we do t…

May 26, 2016
billonahill commented on issue twitter/heron#799
@billonahill

As expected this is proving difficult to do in bazel. The sh_binary target needs to be able to get the checkstyle jars and configs as well as all j…

May 26, 2016
billonahill commented on issue twitter/heron#799
@billonahill

For item 2 above, theory confirmed. If would implement something like this, maybe as a sh_binary that relies on the checkstyle java_library, we'd b…

May 26, 2016
billonahill commented on issue twitter/heron#799
@billonahill

@maosongfu ran a build without stylechecks (was that just java, or python, c too?) and the build time dropped by 20-30 minutes so we should pursue …

May 26, 2016
billonahill commented on pull request twitter/heron#798
@billonahill

The issue as I see it re hugo is that while many of us can browse from docs to javadocs without issue (for example you can go from http://localhost…

May 26, 2016
billonahill commented on issue twitter/heron#813
@billonahill

Thanks for the report @efenderbosch. Relates to #747. @kramasamy do you have that image?

May 26, 2016
@billonahill
  • @jmcomets 6de3111
    Fix 404 link in README (#783)
May 26, 2016
billonahill merged pull request twitter/heron#783
@billonahill
Fix 404 link in README
2 commits with 1 addition and 1 deletion
May 26, 2016
billonahill commented on pull request twitter/heron#783
@billonahill

Thanks @jmcomets!

May 26, 2016
@billonahill
  • @billonahill 1f144c8
    Change baseurl to not include the hostname (#805)
billonahill deleted branch billg/change_baserl at billonahill/heron
May 26, 2016
May 26, 2016
billonahill merged pull request twitter/heron#805
@billonahill
Change baseurl to not include the hostname
1 commit with 1 addition and 1 deletion
May 26, 2016
billonahill opened pull request twitter/heron#805
@billonahill
Change baseurl to not include the hostname
1 commit with 1 addition and 1 deletion
May 26, 2016
May 26, 2016
@billonahill
  • @billonahill db0ed02
    website doc publishing tweak
May 26, 2016
@billonahill
  • @billonahill 3f01d6d
    website doc publishing tweak
May 26, 2016
@billonahill
May 26, 2016
@billonahill
billonahill deleted branch billg/add_submodule_docs at billonahill/heron
May 26, 2016
May 26, 2016
@billonahill
  • @billonahill f2dff45
    Add docs for how to init submodules (#794)
May 26, 2016
billonahill merged pull request twitter/heron#794
@billonahill
Add docs for how to init submodules
2 commits with 19 additions and 4 deletions
May 26, 2016
billonahill commented on pull request twitter/heron#800
@billonahill

Just saw the same change in #798. Let's discuss there.

Something went wrong with that request. Please try again.