New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fancy currency symbols #8

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@brianmed

brianmed commented Jan 20, 2016

Here are some fancy currency symbols. If there is interest, I can update the documentation and possibly add some more tests.

@billward

This comment has been minimized.

Show comment
Hide comment
@billward

billward Jan 20, 2016

Owner

Interesting ... If we do this, I would prefer to keep the code in ASCII and
use the Unicode escaping syntax for double quoted strings such as \x{NNNN}
or \N{NAME}. Also the format_price method accepts a symbol argument, so we
can use that in the test suite to format using these strings. It should
also be possible to set the internal currency_symbol or int_curr_symbol to
one of these strings. Would you like to work on those changes?

On Wed, Jan 20, 2016 at 8:38 AM, brianmed notifications@github.com wrote:

Here are some fancy currency symbols. If there is interest, I can update

the documentation and possibly add some more tests.

You can view, comment on, or merge this pull request online at:

#8
Commit Summary

  • Some fancy currency symbols

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#8.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward • Flickr
http://flickr.com/photos/billward/ • Twitter
http://twitter.com/williamward • LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ • Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

Owner

billward commented Jan 20, 2016

Interesting ... If we do this, I would prefer to keep the code in ASCII and
use the Unicode escaping syntax for double quoted strings such as \x{NNNN}
or \N{NAME}. Also the format_price method accepts a symbol argument, so we
can use that in the test suite to format using these strings. It should
also be possible to set the internal currency_symbol or int_curr_symbol to
one of these strings. Would you like to work on those changes?

On Wed, Jan 20, 2016 at 8:38 AM, brianmed notifications@github.com wrote:

Here are some fancy currency symbols. If there is interest, I can update

the documentation and possibly add some more tests.

You can view, comment on, or merge this pull request online at:

#8
Commit Summary

  • Some fancy currency symbols

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#8.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward • Flickr
http://flickr.com/photos/billward/ • Twitter
http://twitter.com/williamward • LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ • Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

@brianmed

This comment has been minimized.

Show comment
Hide comment
@brianmed

brianmed Jan 20, 2016

?Sure!

I'm moving this week, so give me some time.


From: Bill Ward notifications@github.com
Sent: Wednesday, January 20, 2016 10:52 AM
To: billward/number-format-perl
Cc: Brian Medley
Subject: Re: [number-format-perl] Some fancy currency symbols (#8)

Interesting ... If we do this, I would prefer to keep the code in ASCII and
use the Unicode escaping syntax for double quoted strings such as \x{NNNN}
or \N{NAME}. Also the format_price method accepts a symbol argument, so we
can use that in the test suite to format using these strings. It should
also be possible to set the internal currency_symbol or int_curr_symbol to
one of these strings. Would you like to work on those changes?

On Wed, Jan 20, 2016 at 8:38 AM, brianmed notifications@github.com wrote:

Here are some fancy currency symbols. If there is interest, I can update

the documentation and possibly add some more tests.

You can view, comment on, or merge this pull request online at:

#8
Commit Summary

  • Some fancy currency symbols

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#8.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward * Flickr
http://flickr.com/photos/billward/ * Twitter
http://twitter.com/williamward * LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ * Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-173269847.

brianmed commented Jan 20, 2016

?Sure!

I'm moving this week, so give me some time.


From: Bill Ward notifications@github.com
Sent: Wednesday, January 20, 2016 10:52 AM
To: billward/number-format-perl
Cc: Brian Medley
Subject: Re: [number-format-perl] Some fancy currency symbols (#8)

Interesting ... If we do this, I would prefer to keep the code in ASCII and
use the Unicode escaping syntax for double quoted strings such as \x{NNNN}
or \N{NAME}. Also the format_price method accepts a symbol argument, so we
can use that in the test suite to format using these strings. It should
also be possible to set the internal currency_symbol or int_curr_symbol to
one of these strings. Would you like to work on those changes?

On Wed, Jan 20, 2016 at 8:38 AM, brianmed notifications@github.com wrote:

Here are some fancy currency symbols. If there is interest, I can update

the documentation and possibly add some more tests.

You can view, comment on, or merge this pull request online at:

#8
Commit Summary

  • Some fancy currency symbols

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#8.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward * Flickr
http://flickr.com/photos/billward/ * Twitter
http://twitter.com/williamward * LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ * Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-173269847.

@billward

This comment has been minimized.

Show comment
Hide comment
@billward

billward Jan 20, 2016

Owner

No rush. The whole of CPAN seems to be back burnered these days anyway.
If we use the \N{NAME} then the names used for the symbols should match the
Unicode names for them, do you agree?

On Wed, Jan 20, 2016 at 8:56 AM, brianmed notifications@github.com wrote:

?Sure!

I'm moving this week, so give me some time.


From: Bill Ward notifications@github.com
Sent: Wednesday, January 20, 2016 10:52 AM
To: billward/number-format-perl
Cc: Brian Medley
Subject: Re: [number-format-perl] Some fancy currency symbols (#8)

Interesting ... If we do this, I would prefer to keep the code in ASCII and
use the Unicode escaping syntax for double quoted strings such as \x{NNNN}
or \N{NAME}. Also the format_price method accepts a symbol argument, so we
can use that in the test suite to format using these strings. It should
also be possible to set the internal currency_symbol or int_curr_symbol to
one of these strings. Would you like to work on those changes?

On Wed, Jan 20, 2016 at 8:38 AM, brianmed notifications@github.com
wrote:

Here are some fancy currency symbols. If there is interest, I can update

the documentation and possibly add some more tests.

You can view, comment on, or merge this pull request online at:

#8
Commit Summary

  • Some fancy currency symbols

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#8.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward * Flickr
http://flickr.com/photos/billward/ * Twitter
http://twitter.com/williamward * LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ * Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

Reply to this email directly or view it on GitHub<
#8 (comment)

.


Reply to this email directly or view it on GitHub
#8 (comment)
.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward • Flickr
http://flickr.com/photos/billward/ • Twitter
http://twitter.com/williamward • LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ • Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

Owner

billward commented Jan 20, 2016

No rush. The whole of CPAN seems to be back burnered these days anyway.
If we use the \N{NAME} then the names used for the symbols should match the
Unicode names for them, do you agree?

On Wed, Jan 20, 2016 at 8:56 AM, brianmed notifications@github.com wrote:

?Sure!

I'm moving this week, so give me some time.


From: Bill Ward notifications@github.com
Sent: Wednesday, January 20, 2016 10:52 AM
To: billward/number-format-perl
Cc: Brian Medley
Subject: Re: [number-format-perl] Some fancy currency symbols (#8)

Interesting ... If we do this, I would prefer to keep the code in ASCII and
use the Unicode escaping syntax for double quoted strings such as \x{NNNN}
or \N{NAME}. Also the format_price method accepts a symbol argument, so we
can use that in the test suite to format using these strings. It should
also be possible to set the internal currency_symbol or int_curr_symbol to
one of these strings. Would you like to work on those changes?

On Wed, Jan 20, 2016 at 8:38 AM, brianmed notifications@github.com
wrote:

Here are some fancy currency symbols. If there is interest, I can update

the documentation and possibly add some more tests.

You can view, comment on, or merge this pull request online at:

#8
Commit Summary

  • Some fancy currency symbols

File Changes

Patch Links:

Reply to this email directly or view it on GitHub
#8.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward * Flickr
http://flickr.com/photos/billward/ * Twitter
http://twitter.com/williamward * LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ * Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

Reply to this email directly or view it on GitHub<
#8 (comment)

.


Reply to this email directly or view it on GitHub
#8 (comment)
.

Check out my LEGO blog at brickpile.com http://www.brickpile.com/
Follow/friend me: Facebook http://facebook.com/billward • Flickr
http://flickr.com/photos/billward/ • Twitter
http://twitter.com/williamward • LinkedIn
http://www.linkedin.com/pub/william-ward/63/393/985/ • Goodreads
https://www.goodreads.com/user/show/2554312-bill-ward

@brianmed

This comment has been minimized.

Show comment
Hide comment
@brianmed

brianmed Jan 20, 2016

Also, this is for the CPAN Pull Request Challenge - 2016

brianmed commented Jan 20, 2016

Also, this is for the CPAN Pull Request Challenge - 2016

@billward

please change to use \X or \N syntax as described in comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment