Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

"Blinking" original outlet content. #31

Closed
nathanhammond opened this Issue · 4 comments

4 participants

@nathanhammond

Reproduction, tested in Chrome 31, OS X 10.8:

Go to: http://ember-animated-outlet-demo.herokuapp.com/

Paste into your console:

App.__container__.lookup("route:application")._actions.goToInvoices = function() {
  this.transitionToAnimated('invoices', {main: 'slideOverLeft'});
}

Note that the original content on the screen blinks just before the animation begins.

Expected behavior: buttery smooth, no blinking. :)

(I'm not in need of a fix, just drawing your attention to this in case you hadn't noticed.)

@mjackson

I've experienced this same issue. It seems that 78bf53c is responsible for the flicker.

@sebastianseilund Can you please clarify what timing issue you were trying to address with that commit?

@nathanhammond

@mjijackson @sebastianseilund It seems like it might be possible to solve it using Ember run loop scheduling for the callback...

@vespertilian

First up thanks for all your hard work on Ember animations @sebastianseilund.

I have the same issue with the slide in over. I created a JS Fiddle of it here: http://jsfiddle.net/cameronbatt/ZV8EV/ You can clearly see the flash when you click the "Two slide over" link. I added a debugger to "didInsertElement" and if you open your console it will pause on the flash.

@sebastianseilund

Thanks for brining this to my attention. I think I know where the problem lies. I'll take a shot at a fix shortly.

I've experienced this same issue. It seems that 78bf53c is responsible for the flicker.

This issue is about the slideOver effect. Are you also experiencing issues with slide? If so, could you please open a separate issue that describes it?

It seems like it might be possible to solve it using Ember run loop scheduling for the callback

I don't think that will help anything. The problem is probably because the css classes in the slideOver effect is applied after a delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.