New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't decrease FileSize on write #107

Merged
merged 2 commits into from Sep 16, 2017

Conversation

2 participants
@saibotu
Contributor

saibotu commented Sep 15, 2017

This prevents decreasing the reported FileSize/EndOfFile when only part of a file is written, which fixes compatibility with various applications.

@billziss-gh

This comment has been minimized.

Owner

billziss-gh commented Sep 15, 2017

@saibotu thanks for the PR. It does seem that you have identified a straight bug and provided a fix for it. THANK YOU!

I am not sure how this has not been caught by any tests. FSX is pretty good at catching things like this (but I note now that it is not being run for any of the example FUSE file systems). I am going to test locally and confirm the problem and its resolution.

Lastly in order for me to accept contributions to this project I require that you add your name and email address to the Contributors document: https://github.com/billziss-gh/winfsp/blob/master/Contributors.asciidoc

This effectively signs the document, assigns joint copyright to your change and identifies you as a contributor. You only need to do this one time on your first contribution.

@billziss-gh

This comment has been minimized.

Owner

billziss-gh commented Sep 16, 2017

@saibotu thank you for signing the agreement.

I have tested the PR locally with FSX. A WinFsp-FUSE file system (e.g. passthrough-fuse) fails fast under FSX without your fix. FSX has no complaints when your fix is added.

I am accepting this PR. I have also modified the WinFsp test suite to run FSX over passthrough-fuse; this will be the next commit.

@billziss-gh billziss-gh merged commit 18bf6ca into billziss-gh:master Sep 16, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@saibotu saibotu deleted the saibotu:pr-writesize branch Sep 17, 2017

@billziss-gh billziss-gh added this to the v1.2 milestone Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment