From 34c5f716ace14b09fd2bac295d4a0e5d581c0937 Mon Sep 17 00:00:00 2001
From: NicolasRichel <nicolas@bimdata.io>
Date: Fri, 10 Mar 2023 17:37:19 +0100
Subject: [PATCH 1/4] feat(files): add drag & drop to specific folder

---
 .../specific/files/files-manager/FilesManager.vue | 11 ++++-------
 .../specific/files/files-table/FilesTable.vue     | 15 +++++++++++----
 src/utils/async.js                                |  4 ++--
 3 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/src/components/specific/files/files-manager/FilesManager.vue b/src/components/specific/files/files-manager/FilesManager.vue
index 5828f1636..d358bc50c 100644
--- a/src/components/specific/files/files-manager/FilesManager.vue
+++ b/src/components/specific/files/files-manager/FilesManager.vue
@@ -217,7 +217,7 @@
             @file-uploaded="$emit('file-uploaded')"
             @dragover.prevent="() => {}"
             @drop.prevent="uploadFiles"
-            @row-drop="({ data, event }) => null"
+            @row-drop="({ event, data }) => uploadFiles(event, data)"
             @selection-changed="setSelection"
             @manage-access="openAccessManager"
             @open-visa-manager="openVisaManager"
@@ -462,17 +462,14 @@ export default {
 
     const filesToUpload = ref([]);
     const foldersToUpload = ref([]);
-    const uploadFiles = async (event, folder) => {
+    const uploadFiles = async (event, folder = currentFolder.value) => {
       const { files, folders } = await getFilesFromEvent(event);
+      files.forEach(file => (file.folder = folder));
 
       filesToUpload.value = files;
       foldersToUpload.value = await Promise.all(
         folders.map(f =>
-          FileService.createFolderStructure(
-            props.project,
-            folder ?? currentFolder.value,
-            f
-          )
+          FileService.createFolderStructure(props.project, folder, f)
         )
       );
 
diff --git a/src/components/specific/files/files-table/FilesTable.vue b/src/components/specific/files/files-table/FilesTable.vue
index c53bf878a..59c19d5b1 100644
--- a/src/components/specific/files/files-table/FilesTable.vue
+++ b/src/components/specific/files/files-table/FilesTable.vue
@@ -10,8 +10,8 @@
     :rowHeight="54"
     :selectable="true"
     @selection-changed="$emit('selection-changed', $event)"
+    @row-drop="onRowDrop"
     :placeholder="$t('FilesTable.emptyTablePlaceholder')"
-    @row-dropped-over="$emit('row-dropped-over', $event)"
   >
     <template #sub-header>
       <div
@@ -40,7 +40,7 @@
           :key="file.key"
           condensed
           :project="project"
-          :folder="folder"
+          :folder="file.folder"
           :file="file"
           @upload-completed="onUploadCompleted(file.key, $event)"
           @upload-canceled="cleanUpload(file.key, 6000)"
@@ -161,10 +161,10 @@ export default {
     "manage-access",
     "open-versioning-manager",
     "open-visa-manager",
-    "selection-changed",
     "open-tag-manager",
     "remove-model",
-    "row-dropped-over"
+    "row-drop",
+    "selection-changed"
   ],
   setup(props, { emit }) {
     const { t } = useI18n();
@@ -189,6 +189,12 @@ export default {
       }));
     });
 
+    const onRowDrop = ({ event, data }) => {
+      event.preventDefault();
+      event.stopPropagation();
+      emit("row-drop", { event, data });
+    };
+
     let nameEditMode;
     watch(
       () => props.files,
@@ -250,6 +256,7 @@ export default {
       cleanUpload,
       formatBytes,
       isFolder,
+      onRowDrop,
       onUploadCompleted,
       // Responsive breakpoints
       isXL
diff --git a/src/utils/async.js b/src/utils/async.js
index 074f264ac..098aac896 100644
--- a/src/utils/async.js
+++ b/src/utils/async.js
@@ -4,9 +4,9 @@ function delay(ms) {
 
 function debounce(callback, ms) {
   let timeoutID = null;
-  return () => {
+  return function () {
     clearTimeout(timeoutID);
-    timeoutID = setTimeout(callback, ms);
+    timeoutID = setTimeout(() => callback(...arguments), ms);
   };
 }
 

From 246781496ebd4c227c09aa703b9ac861b7d048de Mon Sep 17 00:00:00 2001
From: NicolasRichel <nicolas@bimdata.io>
Date: Mon, 13 Mar 2023 14:35:01 +0100
Subject: [PATCH 2/4] fix(utils): use explicit args forwarding in debounce
 utils

---
 src/utils/async.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/utils/async.js b/src/utils/async.js
index 098aac896..8efd8b288 100644
--- a/src/utils/async.js
+++ b/src/utils/async.js
@@ -4,9 +4,9 @@ function delay(ms) {
 
 function debounce(callback, ms) {
   let timeoutID = null;
-  return function () {
+  return (...args) => {
     clearTimeout(timeoutID);
-    timeoutID = setTimeout(() => callback(...arguments), ms);
+    timeoutID = setTimeout(() => callback(...args), ms);
   };
 }
 

From 8fcd49ccb1c215ae81251c95349f190ff6a1c52f Mon Sep 17 00:00:00 2001
From: Kurtil <gaetan.lagier@hotmail.fr>
Date: Wed, 29 Mar 2023 17:04:32 +0200
Subject: [PATCH 3/4] add special style to drag overed folders

---
 package-lock.json                                         | 8 ++++----
 package.json                                              | 2 +-
 .../specific/files/files-manager/FilesManager.vue         | 2 +-
 src/components/specific/files/files-table/FilesTable.vue  | 8 ++++++++
 4 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 22aad77df..0ec49ba1f 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -10,7 +10,7 @@
       "dependencies": {
         "@bimdata/bcf-components": "4.1.0-rc.4",
         "@bimdata/building-maker": "1.5.2",
-        "@bimdata/design-system": "2.0.0-rc.1",
+        "@bimdata/design-system": "2.0.0-rc.4",
         "@bimdata/guided-tour-components": "1.0.3",
         "@bimdata/typescript-fetch-api-client": "9.6.4",
         "@bimdata/viewer": "^1.10.0-rc.45",
@@ -603,9 +603,9 @@
       }
     },
     "node_modules/@bimdata/design-system": {
-      "version": "2.0.0-rc.1",
-      "resolved": "https://registry.npmjs.org/@bimdata/design-system/-/design-system-2.0.0-rc.1.tgz",
-      "integrity": "sha512-i5T/ZwxuYTcbRBqf76CX/iWMP3d60yQeL5j4fxknaJXzFqauE4ilDhtYWO0NVa8u5JeL9isSg22+NFJzoDyldQ=="
+      "version": "2.0.0-rc.4",
+      "resolved": "https://registry.npmjs.org/@bimdata/design-system/-/design-system-2.0.0-rc.4.tgz",
+      "integrity": "sha512-UentERGTzb6kVCAbhYdCjtDiJLm08E6rnpBCvvg9024Ra+y+hZYRcDCwVOAwVd07rKMevGwefm49idcjABerLQ=="
     },
     "node_modules/@bimdata/guided-tour-components": {
       "version": "1.0.3",
diff --git a/package.json b/package.json
index a859d04a0..39ea47f1d 100644
--- a/package.json
+++ b/package.json
@@ -13,7 +13,7 @@
   "dependencies": {
     "@bimdata/bcf-components": "4.1.0-rc.4",
     "@bimdata/building-maker": "1.5.2",
-    "@bimdata/design-system": "2.0.0-rc.1",
+    "@bimdata/design-system": "2.0.0-rc.4",
     "@bimdata/guided-tour-components": "1.0.3",
     "@bimdata/typescript-fetch-api-client": "9.6.4",
     "@bimdata/viewer": "^1.10.0-rc.45",
diff --git a/src/components/specific/files/files-manager/FilesManager.vue b/src/components/specific/files/files-manager/FilesManager.vue
index d358bc50c..86b29e70f 100644
--- a/src/components/specific/files/files-manager/FilesManager.vue
+++ b/src/components/specific/files/files-manager/FilesManager.vue
@@ -215,7 +215,7 @@
             @download="downloadFiles([$event])"
             @file-clicked="onFileSelected"
             @file-uploaded="$emit('file-uploaded')"
-            @dragover.prevent="() => {}"
+            @dragover.prevent
             @drop.prevent="uploadFiles"
             @row-drop="({ event, data }) => uploadFiles(event, data)"
             @selection-changed="setSelection"
diff --git a/src/components/specific/files/files-table/FilesTable.vue b/src/components/specific/files/files-table/FilesTable.vue
index 59c19d5b1..84e491745 100644
--- a/src/components/specific/files/files-table/FilesTable.vue
+++ b/src/components/specific/files/files-table/FilesTable.vue
@@ -6,6 +6,7 @@
     tableLayout="fixed"
     :columns="columns"
     :rows="files"
+    :canDragOverRow="file => !file.file"
     rowKey="id"
     :rowHeight="54"
     :selectable="true"
@@ -264,3 +265,10 @@ export default {
   }
 };
 </script>
+
+<style>
+.bimdata-table__row--drag-overed {
+  outline: solid var(--color-primary) 1px;
+  outline-offset: -1px;
+}
+</style>
\ No newline at end of file

From 4570d39969b1c06d46db425f3bdfc2732709e247 Mon Sep 17 00:00:00 2001
From: Kurtil <gaetan.lagier@hotmail.fr>
Date: Thu, 30 Mar 2023 10:32:45 +0200
Subject: [PATCH 4/4] cypress.env.example -> cypress.env.json.example

---
 README.md                                       | 2 +-
 cypress.env.example => cypress.env.json.example | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename cypress.env.example => cypress.env.json.example (100%)

diff --git a/README.md b/README.md
index 6d2fc33f5..f9393dc70 100644
--- a/README.md
+++ b/README.md
@@ -67,7 +67,7 @@ Before you can run the tests you need to have a working test environment.
 To do so copy the example env file:
 
 ```
-$ cp cyress.env.example cypress.env.json
+$ cp cyress.env.json.example cypress.env.json
 ```
 
 Then open it and set variables values as appropriate:
diff --git a/cypress.env.example b/cypress.env.json.example
similarity index 100%
rename from cypress.env.example
rename to cypress.env.json.example