From 9fa3f484e941e248e4b6293ef31608df02cd5645 Mon Sep 17 00:00:00 2001
From: NicolasRichel <nicolas@bimdata.io>
Date: Fri, 27 Oct 2023 11:15:32 +0200
Subject: [PATCH] fix(space-card): make favorite btn available to non admin
 users

---
 src/components/specific/app/app-header/AppHeader.scss        | 1 +
 src/components/specific/spaces/space-card/SpaceCard.vue      | 5 +----
 .../space-card-action-menu/SpaceCardActionMenu.scss          | 3 ---
 .../space-card-action-menu/SpaceCardActionMenu.vue           | 5 ++++-
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/components/specific/app/app-header/AppHeader.scss b/src/components/specific/app/app-header/AppHeader.scss
index 66f15592a..6cab9d0f4 100644
--- a/src/components/specific/app/app-header/AppHeader.scss
+++ b/src/components/specific/app/app-header/AppHeader.scss
@@ -21,6 +21,7 @@
   }
 
   &__invit-btn {
+    position: relative;
     margin: 0 var(--spacing-unit);
 
     &__notif {
diff --git a/src/components/specific/spaces/space-card/SpaceCard.vue b/src/components/specific/spaces/space-card/SpaceCard.vue
index 291559fcc..2aeb8cc18 100644
--- a/src/components/specific/spaces/space-card/SpaceCard.vue
+++ b/src/components/specific/spaces/space-card/SpaceCard.vue
@@ -6,10 +6,7 @@
   >
     <BIMDataCard class="space-card">
       <template #right>
-        <SpaceCardActionMenu
-          v-if="actionMenu && space.isAdmin"
-          :space="space"
-        />
+        <SpaceCardActionMenu v-if="actionMenu" :space="space" />
       </template>
       <template #content>
         <div v-if="space.isFree" class="free-badge">
diff --git a/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.scss b/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.scss
index 95229b187..9e4ac687b 100644
--- a/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.scss
+++ b/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.scss
@@ -8,12 +8,9 @@
   }
 
   &__container {
-    $card-menu-height: 132px;
-
     position: absolute;
     right: 0;
     width: calc(#{$card-width} - var(--spacing-unit));
-    min-height: $card-menu-height;
     margin-top: calc(var(--spacing-unit) / 2);
     padding: calc(var(--spacing-unit) / 2) 0;
     border-radius: 4px;
diff --git a/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.vue b/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.vue
index 0a5180719..f72db153c 100644
--- a/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.vue
+++ b/src/components/specific/spaces/space-card/space-card-action-menu/SpaceCardActionMenu.vue
@@ -48,6 +48,7 @@
                 }}
               </BIMDataButton>
               <BIMDataButton
+                v-if="space.isAdmin"
                 data-test-id="btn-open-update"
                 ghost
                 squared
@@ -56,12 +57,13 @@
                 {{ $t("t.rename") }}
               </BIMDataButton>
               <SpaceCardImageButton
+                v-if="space.isAdmin"
                 data-test-id="btn-update-image"
                 :space="space"
                 @upload-completed="closeMenu"
               />
               <BIMDataButton
-                v-if="space.image"
+                v-if="space.isAdmin && space.image"
                 data-test-id="btn-delete-image"
                 ghost
                 squared
@@ -70,6 +72,7 @@
                 {{ $t("SpaceCardActionMenu.removeImageButtonText") }}
               </BIMDataButton>
               <BIMDataButton
+                v-if="space.isAdmin"
                 data-test-id="btn-open-delete"
                 color="high"
                 ghost