From 1beca38986044c74426addf80d2669e9cb4d3c07 Mon Sep 17 00:00:00 2001 From: Aaron Imming Date: Fri, 22 Feb 2019 18:19:44 +0800 Subject: [PATCH 1/2] Stop sending undefined version to TrackJS --- src/botPage/view/index.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/botPage/view/index.js b/src/botPage/view/index.js index 4a64f7c549..2dbf151553 100644 --- a/src/botPage/view/index.js +++ b/src/botPage/view/index.js @@ -5,7 +5,6 @@ import 'notifyjs-browser'; import '../../common/binary-ui/dropdown'; import Elevio from '../../common/elevio'; import View from './View'; -import { version } from '../../../package.json'; $.ajaxSetup({ cache: false, @@ -31,7 +30,6 @@ view.initPromise.then(() => { $('.barspinner').hide(); window.dispatchEvent(new Event('resize')); Elevio.init(); - trackJs.addMetadata('version', version); trackJs.configure({ userId: $('.account-id') .first() From c3c87e2d3812ed495fecdcf6a0cb093383cacb8c Mon Sep 17 00:00:00 2001 From: Aaron Imming Date: Fri, 22 Feb 2019 18:20:06 +0800 Subject: [PATCH 2/2] Remove undefined version from CLI --- src/botPage/bot/cli.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/botPage/bot/cli.js b/src/botPage/bot/cli.js index 7ddfeffe4c..3e6f77b456 100644 --- a/src/botPage/bot/cli.js +++ b/src/botPage/bot/cli.js @@ -3,7 +3,6 @@ import fs from 'fs'; import readline from 'readline'; import program from 'commander'; import { observer as globalObserver } from '../../common/utils/observer'; -import { version } from '../../../package.json'; import { createInterpreter } from './CliTools'; const log = (...args) => console.log(`${new Date().toLocaleTimeString()}:`, ...args); // eslint-disable-line no-console @@ -15,7 +14,6 @@ setInterval(() => {}, 2147483647); // Keep node alive let filename; program - .version(version) .usage('[filename]') .arguments('[filename]') .action(fn => {