Binary com lp new #3667
Binary com lp new #3667
Conversation
Mitra/Row move to deriv landing page
…ction Mitra/Add exclusively on deriv section
Pavel/MTD carousel
Mitra/Update some content
Pavel/take-deriv
Pavel/fix: autoplay carousel
Mitra/Hero banner
Pavel/show langbar
Pavel / fix btn urls
Mitra/Fix circle ci test
src/indexPage/index.js
Outdated
| Component = <BotLanding />; | ||
| dynamicVar = 'bot-landing'; | ||
| } | ||
| console.log(Component, dynamicVar); |
There was a problem hiding this comment.
Do we need to keep the console here?
src/botPage/view/View.js
Outdated
| let Component, dynVar; | ||
| if (window.location.pathname === '/movetoderv.html') { | ||
| Component = <BinaryLanding />; | ||
| dynVar = 'movetoderiv'; |
There was a problem hiding this comment.
so where are we using dynVar?
src/indexPage/index.js
Outdated
| render(<BotLanding />, document.getElementById('bot-landing')); | ||
| setStorage('setDueDateForBanner', expirationDate()); | ||
| let Component, dynamicVar; | ||
| if (window.location.pathname === '/movetoderiv.html') { |
There was a problem hiding this comment.
We are repeating the same thing in renderReactComponents .. can we use 1 component?
src/indexPage/index.js
Outdated
| const renderElements = () => { | ||
| // eslint-disable-next-line one-var, no-unused-vars | ||
| let Component, dynamicVar; | ||
| if (window.location.pathname === '/movetoderiv.html') { |
| autoplaySpeed : 3000, | ||
| responsive : [ | ||
| { | ||
| breakpoint: 1024, |
There was a problem hiding this comment.
can we use the breakpoint variables instead of 1024?
There was a problem hiding this comment.
Thanks @sara-fs, This is actually the carousel setting itself and we are using it once only 🙏
| }, | ||
| }, | ||
| { | ||
| breakpoint: 700, |
| <img src="image/binary.png" /> | ||
| </a> | ||
| </div> | ||
| <a href="https://oauth.deriv.com/oauth2/authorize?app_id=16929&l=en&brand=deriv" className="navigation-to-deriv" rel="noopener noreferrer"> |
There was a problem hiding this comment.
appid should be const here?
| </a> | ||
| </div> | ||
| <a href="https://oauth.deriv.com/oauth2/authorize?app_id=16929&l=en&brand=deriv" className="navigation-to-deriv" rel="noopener noreferrer"> | ||
| <button className='btn-group r-btn'> |
There was a problem hiding this comment.
it was better and moe readable if we used complete word for variable names like right-btn
| {translate('Just log in using your Binary.com credentials. No sign-up needed.')} | ||
| </h2> | ||
| <div className="btn-group"> | ||
| <a href="https://oauth.deriv.com/oauth2/authorize?app_id=16929&l=en&brand=deriv" rel="noopener noreferrer"> |
static/css/_carousel.scss
Outdated
|
|
||
| h1 { | ||
| text-align: center; | ||
| margin-top: 80px; |
| } | ||
| } | ||
|
|
||
| .carousel_section { |
There was a problem hiding this comment.
the name should be carousel-section
_ underline is being used to mention the element and -- for mentioning the modifier so to avoid confusion we usually dont use _ for the root name
http://getbem.com/naming/
There was a problem hiding this comment.
Thanks dear @sara-fs, we will create a new PR for these changes later 🙏
| .carousel_section { | ||
|
|
||
| &__desktop { | ||
| @media (max-width: 768px) { |
There was a problem hiding this comment.
no const variables for break points?
|
|
||
| } | ||
|
|
||
| &__slide_img { |
There was a problem hiding this comment.
__slide-img
and the rest ...
static/css/_mtd-langbar.scss
Outdated
|
|
||
| // .language_list { | ||
| // padding-top: 26px !important; | ||
| // display: flex !important; |
Fixes #1, Fixes #2