From de404ce2325fd354f5328fc95e2fbc03b5b7140e Mon Sep 17 00:00:00 2001 From: kate-deriv Date: Tue, 31 Jan 2023 16:05:52 +0300 Subject: [PATCH 1/3] fix: add check for undefined values and add key for React Fragment after map method --- src/javascript/app/pages/trade/markets.jsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/javascript/app/pages/trade/markets.jsx b/src/javascript/app/pages/trade/markets.jsx index 14edc1ffc40b6..8a5216e920f60 100644 --- a/src/javascript/app/pages/trade/markets.jsx +++ b/src/javascript/app/pages/trade/markets.jsx @@ -124,7 +124,11 @@ class Markets extends React.Component { let market_symbol = Defaults.get('market'); const market_list = Symbols.markets(); this.markets = getAvailableUnderlyings(market_list); - delete this.markets.forex.submarkets.smart_fx; + + if (this.markets.forex) { + delete this.markets.forex.submarkets.smart_fx; + } + this.underlyings = Symbols.getAllSymbols() || {}; let underlying_symbol = Defaults.get('underlying'); @@ -585,11 +589,11 @@ class Markets extends React.Component {
    - {Object.keys(group_markets).map((item) => { + {Object.keys(group_markets).map((item, index) => { const derived_category = group_markets[item].markets[0].key; return ( item === 'none' ? ( - + {group_markets[item].markets.map((m) => (
  • Date: Tue, 31 Jan 2023 16:53:46 +0300 Subject: [PATCH 2/3] refactor: change key for react fragment --- src/javascript/app/pages/trade/markets.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/javascript/app/pages/trade/markets.jsx b/src/javascript/app/pages/trade/markets.jsx index 8a5216e920f60..4a6685d0b06d8 100644 --- a/src/javascript/app/pages/trade/markets.jsx +++ b/src/javascript/app/pages/trade/markets.jsx @@ -589,11 +589,11 @@ class Markets extends React.Component {
      - {Object.keys(group_markets).map((item, index) => { + {Object.keys(group_markets).map((item, idx) => { const derived_category = group_markets[item].markets[0].key; return ( item === 'none' ? ( - + {group_markets[item].markets.map((m) => (
    • Date: Tue, 31 Jan 2023 18:14:52 +0300 Subject: [PATCH 3/3] refactor: add an empty commit