fix: incorrect test case and function refactor

Author: akmal-deriv

packages/shared/src/utils/date/__tests__/date-time.spec.ts

@@ -71,9 +71,9 @@ describe('formatDate', () => {
         expect(DateTime.formatDate(date, date_format, true)).toEqual(moment(date).format(date_format));
     });
 
-    it('returns undefined when date is not null and should_format_null is false', () => {
+    it('returns formatted date when date is not null and should_format_null is false', () => {
         const date = moment('2023-09-20').utc();
-        expect(DateTime.formatDate(date, date_format, false)).toBeUndefined();
+        expect(DateTime.formatDate(date, date_format, false)).toEqual(moment(date).format(date_format));
     });
 });
 

packages/shared/src/utils/date/date-time.ts

@@ -74,7 +74,7 @@ export const toGMTFormat = (time?: moment.MomentInput) =>
         .format('YYYY-MM-DD HH:mm:ss [GMT]');
 
 export const formatDate = (date?: moment.MomentInput, date_format = 'YYYY-MM-DD', should_format_null = true) =>
-    should_format_null && date !== null ? toMoment(date).format(date_format) : undefined;
+    !should_format_null && date === null ? undefined : toMoment(date).format(date_format);
 
 export const formatTime = (epoch: number | string, time_format = 'HH:mm:ss [GMT]') =>
     toMoment(epoch).format(time_format);