thisyahlen/feat: add CFD section to wallets

[thisyahlen-deriv]

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Sep 18, 2023 3:06am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: thisyahlen/feat: add CFD section to wallets #10092
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-addcfdsec-3aaa58.binary.sx?qa_server=red.binaryws.com&app_id=36517
  • Original: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-addcfdsec-3aaa58.binary.sx
• App ID: 36517

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/10092](https://github.com/binary-com/deriv-app/pull/10092)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-addcfdsec-3aaa58.binary.sx?qa_server=red.binaryws.com&app_id=36517
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-addcfdsec-3aaa58.binary.sx
- **App ID**: `36517`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-addcfdsec-3aaa58.binary.sx/

[coveralls]

coverage: 10.095% (-0.006%) from 10.101% when pulling 71b309d on thisyahlen-deriv:thisyahlen/add_cfd_section_to_wallets into 3fe4a5c on binary-com:master.

[farhan-nurzi-deriv]

Suggested change

	const OtherCFDPlatformsList: React.FC = () => {
	const NonMT5CFDPlatformsList: React.FC = () => {

How about this? 🤔

[farhan-nurzi-deriv]

So we go with React.ReactNode instead of ReactElement? just wanna clarify the standard

[thisyahlen-deriv]

Better to go with reactNode cause its more flexible in terms of children and it doesnt get executed if the function is not fired

[sonarqubecloud]

SonarCloud Quality Gate failed.   

6 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint