-
Notifications
You must be signed in to change notification settings - Fork 394
adrienne / added responsive view for step wrapper and refactored modal wrappers #10411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adrienne / added responsive view for step wrapper and refactored modal wrappers #10411
Conversation
…app into jurisdiction-modal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-wide-mobile-wrapper.binary.sx/ |
|
SonarCloud Quality Gate failed.
|
…l wrappers (#10411) * feat: added wide wrapper for jurisdiction modal * feat: added desktop view for jurisdiction modal * chore: updated package-lock.json for wallets * chore: removed package-lock.json in wallets * chore: updated component typings based on comments * chore: updated comments based on reviews * chore: fixed issues with circleci for wallets * chore: removed duplicated packages in wallets * refactor: added responsive view for step wrapper * chore: removed unused component
…l wrappers (#10411) * feat: added wide wrapper for jurisdiction modal * feat: added desktop view for jurisdiction modal * chore: updated package-lock.json for wallets * chore: removed package-lock.json in wallets * chore: updated component typings based on comments * chore: updated comments based on reviews * chore: fixed issues with circleci for wallets * chore: removed duplicated packages in wallets * refactor: added responsive view for step wrapper * chore: removed unused component











Changes:
Please provide a summary of the change.
We have proposed a new change to the modal structure:
WalletModalto be a modal wrapper. A modal wrapper is just a skeleton/template that only contains styling for a certain modal template. For instance, some modals have header and footer likeMT5AccountTypeModalandJurisdictionModal, while some modals only have a close icon and no header/footer, such asCreatePasswordModalor success modal. Modal wrappers likeModalStepWrapperare templates which have header/footer included, whileModalWrapperis just a plain modal with a close icon.where
<Wrapper>can be a wrapper likeModalStepWrapperandModalWrapper! The important thing to note is that wrappers should not control the behaviour of the modal, only styling of reusable templates.ModalStepWrapperScreenshots:
Please provide some screenshots of the change.