Skip to content

Conversation

@maryia-matskevich-deriv
Copy link
Contributor

Changes:

fix: Snackbar close icon appearance on Safari doesn't match rest of the browsers:

  • Do this for dark theme
  • Do this for light theme

Screenshots:

Screenshot 2023-10-12 at 17 22 31 Screenshot 2023-10-12 at 17 19 50

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 12, 2023 2:34pm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment on lines +250 to 252
transform: translateZ(0);
-webkit-filter: invert(1);
filter: invert(1);
Copy link
Contributor Author

@maryia-matskevich-deriv maryia-matskevich-deriv Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was related to filter: invert(1);
We can see the warning in the safari.
Since the prefix didn't help, but I added it anyway, in some cases forcing GPU acceleration can help.

How it works?
transform: translateZ(0) is a trick to fix graphical artifacts, the browser can optimize the rendering of this element using the GPU. CSS filters can be passed from CPU (central processing unit) to GPU (graphics processing unit)

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10644](https://github.com/binary-com/deriv-app/pull/10644)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-matskevich-deriv-bot-795.binary.sx?qa_server=red.binaryws.com&app_id=24161
    - **Original**: https://deriv-app-git-fork-maryia-matskevich-deriv-bot-795.binary.sx
- **App ID**: `24161`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-bot-795.binary.sx/

@vinu-deriv vinu-deriv merged commit 31d44db into deriv-com:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants