Skip to content

Conversation

@hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.
Windows link changed.
Broker Name changed

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 20, 2023 8:14am

hirad-deriv
hirad-deriv previously approved these changes Oct 20, 2023
@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10841](https://github.com/binary-com/deriv-app/pull/10841)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1246-update-br-c78c25.binary.sx?qa_server=red.binaryws.com&app_id=32186
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1246-update-br-c78c25.binary.sx
- **App ID**: `32186`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1246-update-br-c78c25.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 26.286% (+0.004%) from 26.282% when pulling c8f71c9 on hamza-deriv:hamza/CFDS-1246-update-broker-name-and-links into 374a714 on binary-com:master.

@hirad-deriv hirad-deriv merged commit 9c5cff5 into deriv-com:master Oct 20, 2023
hirad-deriv pushed a commit that referenced this pull request Oct 20, 2023
* chore: update the broker name and windows link

* chore: updated the test case and broker name in constant
vinu-deriv pushed a commit that referenced this pull request Oct 21, 2023
* chore: update the broker name and windows link

* chore: updated the test case and broker name in constant
aum-deriv pushed a commit to aum-deriv/deriv-app that referenced this pull request Oct 23, 2023
* chore: update the broker name and windows link

* chore: updated the test case and broker name in constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants