Skip to content

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Nov 2, 2023

Changes:

  • added loading state inside of button
  • added new isFullscreen prop for loader
  • assign colors based on the colors and variants of the button

Screenshots:

Screenshot 2023-11-02 at 2 22 08 PM

- added loading state inside of button
- added new isFullscreen prop for loader
- assign colors based on the colors and variants of the button
@vercel
Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 2, 2023 7:54am

@aizad-deriv aizad-deriv changed the title feat: adding Loading State inside of Button Aizad/ WALL-2418/ adding Loading State inside of Button Nov 2, 2023
@coveralls
Copy link

Coverage Status

coverage: 27.165%. remained the same when pulling 811cf83 on aizad-deriv:aizad/WALL-2418/loader-for-button into d8d4770 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11128](https://github.com/binary-com/deriv-app/pull/11128)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2418loader-for-button.binary.sx?qa_server=red.derivws.com&app_id=24096
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2418loader-for-button.binary.sx
- **App ID**: `24096`

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-2418loader-for-button.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

🚀 Smoke test run (2) passed successfully!

@yashim-deriv yashim-deriv merged commit d9148e0 into deriv-com:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants