Skip to content

Conversation

@farrah-deriv
Copy link
Contributor

Changes:

Replace span with Text component from ui library.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 1, 2024 11:58am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13295](https://github.com/binary-com/deriv-app/pull/13295)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farrah-deriv-feq-1592-use-text-component.binary.sx?qa_server=red.derivws.com&app_id=24043
    - **Original**: https://deriv-app-git-fork-farrah-deriv-feq-1592-use-text-component.binary.sx
- **App ID**: `24043`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farrah-deriv-feq-1592-use-text-component.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 34.796% (+0.001%) from 34.795%
when pulling 69602a5 on farrah-deriv:FEQ-1592/use-text-component
into 8c9d2a3 on binary-com:master.

@farrah-deriv farrah-deriv merged commit c67dfaf into deriv-com:master Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants