Skip to content

[FEQ]Jim/FEQ-1606/add test cases for paymentmethodsempty #13316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
farrah-deriv merged 16 commits into from
Feb 7, 2024
Merged

[FEQ]Jim/FEQ-1606/add test cases for paymentmethodsempty #13316

farrah-deriv merged 16 commits into from
Feb 7, 2024

Conversation

@jim-deriv
Copy link
Contributor

@jim-deriv jim-deriv commented Feb 2, 2024

Changes:

  • Added test cases for PaymentMethodsEmpty component

Screenshots:

coverage form footer

@vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 7, 2024 6:37am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/13316](https://github.com/binary-com/deriv-app/pull/13316)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-feq-1606add-test-cases-0564fd.binary.sx?qa_server=red.derivws.com&app_id=24104
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-feq-1606add-test-cases-0564fd.binary.sx
- **App ID**: `24104`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-feq-1606add-test-cases-0564fd.binary.sx/

farrah-deriv
farrah-deriv previously approved these changes Feb 2, 2024
View reviewed changes
adrienne-deriv
adrienne-deriv previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into jim/FEQ…
8102b23 
…-1606/add-test-cases-for-payment-methods-empty
@jim-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into jim/FEQ…
aebae2a 
…-1606/add-test-cases-for-payment-methods-empty
adrienne-deriv
adrienne-deriv previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into jim/FEQ…
c753df1 
…-1606/add-test-cases-for-payment-methods-empty
@coveralls
Copy link

coveralls commented Feb 7, 2024 •
edited
Loading

Coverage Status

coverage: 35.415% (+0.01%) from 35.404%
when pulling 9b7c2c7 on jim-deriv:Jim/FEQ-1606/add-test-cases-for-payment-methods-empty
into b23d5db on binary-com:master.

adrienne-deriv
adrienne-deriv approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adrienne-deriv
adrienne-deriv previously approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

farrah-deriv
farrah-deriv previously approved these changes Feb 7, 2024
View reviewed changes
@jim-deriv
Merge branch 'master' of github.com:binary-com/deriv-app into jim/FEQ…
4762f34 
…-1606/add-test-cases-for-payment-methods-empty
@jim-deriv jim-deriv dismissed stale reviews from farrah-deriv and adrienne-deriv via 4762f34 February 7, 2024 05:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

adrienne-deriv
adrienne-deriv approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farrah-deriv farrah-deriv merged commit 472c1b6 into deriv-com:master Feb 7, 2024
@jim-deriv jim-deriv deleted the Jim/FEQ-1606/add-test-cases-for-payment-methods-empty branch September 19, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv

2 more reviewers

@adrienne-deriv adrienne-deriv adrienne-deriv approved these changes

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jim-deriv @coveralls @farrah-deriv @adrienne-deriv @ameerul-deriv