Skip to content

Conversation

@suisin-deriv
Copy link
Contributor

Changes:

Renaming Files to PascalCase from kebab-case and include index.ts files for all components

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 4, 2024 2:18am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13937](https://github.com/binary-com/deriv-app/pull/13937)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-coj640filenamingt-f069e3.binary.sx?qa_server=red.derivws.com&app_id=32479
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-coj640filenamingt-f069e3.binary.sx
- **App ID**: `32479`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟧 Best practices 83
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-coj640filenamingt-f069e3.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.8% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Mar 4, 2024

Coverage Status

coverage: 37.333% (-0.001%) from 37.334%
when pulling d489864 on suisin-deriv:suisin/COJ640/file_naming_to_pascal_case
into 0395a71 on binary-com:master.

@sandeep-deriv sandeep-deriv merged commit 23949a0 into deriv-com:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants