Skip to content

Conversation

@yauheni-deriv
Copy link
Contributor

Changes:

Added dependancy to useEffect to trigger the logic inside 'if' statement

Screenshots:

Screenshot 2024-03-28 at 15 41 04 Screenshot 2024-03-28 at 15 41 46

@vercel
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 28, 2024 1:48pm

heorhi-deriv
heorhi-deriv previously approved these changes Mar 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14392](https://github.com/binary-com/deriv-app/pull/14392)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-evgeniyupm-880analytics-37890f.binary.sx?qa_server=red.derivws.com&app_id=32820
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-evgeniyupm-880analytics-37890f.binary.sx
- **App ID**: `32820`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-evgeniyupm-880analytics-37890f.binary.sx/

@coveralls
Copy link

coveralls commented Mar 28, 2024

Coverage Status

coverage: 39.515%. remained the same
when pulling 80a71f0 on yauheni-deriv:evgeniy_upm-880_analytics-sdk_not_connected
into e389429 on binary-com:master.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@amina-deriv amina-deriv merged commit dfe3893 into deriv-com:master Mar 29, 2024
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Mar 29, 2024
* fix: [UPM-880]/evgeniy/not able to connect to analytics

* chore: added default value for tracking_rudderstack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants