Skip to content

[WALL] Aizad/WALL-3900/Re-add Buttons inside of Compare Account Page #14960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nijil-deriv merged 2 commits into from
May 6, 2024
Merged

[WALL] Aizad/WALL-3900/Re-add Buttons inside of Compare Account Page #14960

nijil-deriv merged 2 commits into from
May 6, 2024

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented May 3, 2024 •
edited
Loading

Changes:

  • Re-add previous and next button inside of Compare Account Page inside of mobile
  • Rename CFDCompareAccountsCard to CompareAccountsCard to match with component name and filename
  • Disable hover background on mobile instead show on active
  • Refactor code

Screenshots:

image

@aizad-deriv aizad-deriv self-assigned this May 3, 2024
@aizad-deriv aizad-deriv requested a review from a user May 3, 2024 07:45
@aizad-deriv aizad-deriv requested a review from heorhi-deriv as a code owner May 3, 2024 07:45
@vercel
Copy link

vercel bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 3, 2024 8:34am

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/14960](https://github.com/binary-com/deriv-app/pull/14960)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-3900re-add-nav-62756f.binary.sx?qa_server=red.derivws.com&app_id=32112
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-3900re-add-nav-62756f.binary.sx
- **App ID**: `32112`

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-3900re-add-nav-62756f.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented May 3, 2024 •
edited
Loading

Coverage Status

coverage: 40.537% (+0.002%) from 40.535%
when pulling 5c1c53d on aizad-deriv:aizad/WALL-3900/re-add-nav-buttons-compare-account
into 362c115 on binary-com:master.

@nijil-deriv nijil-deriv merged commit 8df1a5d into deriv-com:master May 6, 2024
vinu-deriv pushed a commit to vinu-deriv/deriv-app that referenced this pull request May 28, 2024
@aizad-deriv @vinu-deriv
[WALL] Aizad/WALL-3900/Re-add Buttons inside of Compare Account Page (d…
4134ba7 
…eriv-com#14960)

* chore: readd nav buttons inside of compare account page

* chore: icon button style fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nijil-deriv nijil-deriv nijil-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

+3 more reviewers

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@aum-deriv aum-deriv aum-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aizad-deriv aizad-deriv

Labels

Wallets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aizad-deriv @coveralls @nijil-deriv @heorhi-deriv @aum-deriv