Skip to content

Conversation

@nada-deriv
Copy link
Contributor

Changes:

Fix for issue where ads are activated/deactivated automatically when scrolling with too many list items in ads page.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the P2P label Jul 13, 2023
@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 25, 2023 5:12am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9346](https://github.com/binary-com/deriv-app/pull/9346)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1121ads-activated.binary.sx?qa_server=red.binaryws.com&app_id=32127
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1121ads-activated.binary.sx
- **App ID**: `32127`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-1121ads-activated.binary.sx/

@coveralls
Copy link

coveralls commented Jul 13, 2023

Coverage Status

coverage: 8.926% (+0.04%) from 8.884% when pulling 2ff1da9 on nada-deriv:nada/P2PS-1121/ads-activated into 1082e43 on binary-com:master.

Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

farrah-deriv
farrah-deriv previously approved these changes Jul 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@amina-deriv amina-deriv merged commit 71a3263 into deriv-com:master Jul 31, 2023
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Aug 2, 2023
)

* fix: fix for ads are deactivated/activated automatically

* fix: added test case for activate/deactivate

* fix: lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants