Skip to content

Amina/fix: withdrawal_line_shown_twice #9369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jim-deriv merged 5 commits into from
Sep 27, 2023
Merged

Amina/fix: withdrawal_line_shown_twice #9369

jim-deriv merged 5 commits into from
Sep 27, 2023

Conversation

@amina-deriv
Copy link
Contributor

@amina-deriv amina-deriv commented Jul 14, 2023

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 20, 2023 8:40pm

@amina-deriv amina-deriv changed the title Amina/fix: withdrawal_line_shown_twice Amina/fix: withdrawal_line_shown_twice[WIP] Jul 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/9369](https://github.com/binary-com/deriv-app/pull/9369)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-wall1289withdrwalli-2bf59e.binary.sx?qa_server=red.binaryws.com&app_id=24059
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-wall1289withdrwalli-2bf59e.binary.sx
- **App ID**: `24059`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-wall1289withdrwalli-2bf59e.binary.sx/

@amina-deriv amina-deriv changed the title Amina/fix: withdrawal_line_shown_twice[WIP] Amina/fix: withdrawal_line_shown_twice Jul 17, 2023
@coveralls
Copy link

coveralls commented Jul 17, 2023 •
edited
Loading

Coverage Status

coverage: 10.584%. remained the same when pulling 12a886b on amina-deriv:amina/wall1289/withdrwal_limit_text_appears_twice into 790dd16 on binary-com:master.

@amina-deriv amina-deriv force-pushed the amina/wall1289/withdrwal_limit_text_appears_twice branch from 66e4c83 to d337fbb Compare July 17, 2023 07:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

matin-deriv
matin-deriv previously approved these changes Jul 17, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 17, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
14.7% 14.7% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

⏳ Generating Lighthouse report...

@github-actions github-actions bot removed the Stale label Sep 21, 2023
@jim-deriv jim-deriv merged commit ff971f1 into deriv-com:master Sep 27, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@amina-deriv @vinu-deriv
Amina/fix: withdrawal_line_shown_twice (#9369)
a650029 
* fix: withdrawal_line_shown_twice

* fix: account_status

* fix: test case
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@amina-deriv @vinu-deriv
Amina/fix: withdrawal_line_shown_twice (#9369)
9535689 
* fix: withdrawal_line_shown_twice

* fix: account_status

* fix: test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matin-deriv matin-deriv matin-deriv approved these changes

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

+1 more reviewer

@shaheer-deriv shaheer-deriv shaheer-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Account

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amina-deriv @coveralls @matin-deriv @shaheer-deriv @jim-deriv