Skip to content

Conversation

@suisin-deriv
Copy link
Contributor

Changes:

Added Test Cases for Api Token

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 4, 2023 4:26am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9525](https://github.com/binary-com/deriv-app/pull/9525)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-webrel369testcase-58b522.binary.sx?qa_server=red.binaryws.com&app_id=32126
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-webrel369testcase-58b522.binary.sx
- **App ID**: `32126`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-webrel369testcase-58b522.binary.sx/

@coveralls
Copy link

coveralls commented Aug 1, 2023

Coverage Status

coverage: 9.658% (+0.01%) from 9.644% when pulling 9f08ebf on suisin-deriv:suisin/WEBREL369/test_case_for_api_toekn into a69c685 on binary-com:master.

import { TApiContext } from 'Types';

const ApiTokenContext = React.createContext<TApiContext>({});
const ApiTokenContext = React.createContext<TApiContext>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to provide an Initial value towards the ApiContext based on the types given in TApiContext

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 71 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@suisin-deriv
Copy link
Contributor Author

Will merge it into utkarsha's branch since she is refactoring editing the same component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants