fix bug: empty array should not die

Author: chylli

lib/HTML/FormBuilder/Select.pm

@@ -6,6 +6,8 @@ our $VERSION = '0.05';
 
 use Carp;
 use Moo;
+use Data::Dumper;
+
 use namespace::clean;
 
 =head1 NAME
@@ -63,8 +65,12 @@ has name => (
 has options => (
     is  => 'rw',
     isa => sub {
-        die "$_[0] is not ArrayRef[HashRef[Any]]"
-            unless (ref($_[0]) eq 'ARRAY' && ref($_[0][0]) eq 'HASH');
+        my $arg = $_[0];
+        my $msg = Dumper($arg) . " is not ArrayRef[HashRef[Any]]";
+        die $msg if !ref($arg) || ref($arg) ne 'ARRAY';
+        for my $elem (@$arg) {
+            die $msg if (!ref($elem) || ref($elem) ne 'HASH');
+        }
     },
 );
 

t/formbuilder/select.t

@@ -1,6 +1,7 @@
 
 use HTML::FormBuilder::Select;
-use Test::More tests => 24;
+use Test::More tests => 26;
+use Test::Exception;
 use strict;
 
 my $basicselect = HTML::FormBuilder::Select->new(
@@ -70,3 +71,59 @@ unlike $widget_html, qr/value="1" SELECTED/, 'widget_select shows correct value'
 like $widget_html,   qr/ id="basic"/,        'html shows correct id';
 like $widget_html,   qr/ name="Basic"/,      'html shows correct name';
 
+subtest "empty option can create select option", sub {
+    my $select;
+    lives_ok(
+        sub {
+            $select = HTML::FormBuilder::Select->new(
+                id      => 'basic',
+                name    => 'Basic',
+                options => [],
+            );
+
+        },
+        'create empty select list ok'
+    );
+};
+
+subtest "check options data type", sub {
+    throws_ok(
+        sub {
+            HTML::FormBuilder::Select->new(
+                id      => 'basic',
+                name    => 'Basic',
+                options => ["hello",],
+            );
+        },
+        qr/is not ArrayRef\[HashRef\[Any\]\]/,
+        "string is not correct"
+    );
+
+    throws_ok(
+        sub {
+            HTML::FormBuilder::Select->new(
+                id      => 'basic',
+                name    => 'Basic',
+                options => "hello",
+            );
+        },
+        qr/is not ArrayRef\[HashRef\[Any\]\]/,
+        "string is not correct"
+    );
+    throws_ok(
+        sub {
+            HTML::FormBuilder::Select->new(
+                id      => 'basic',
+                name    => 'Basic',
+                options => [{
+                        value => 1,
+                        text  => 'one',
+                    },
+                    "hello",
+                ]);
+        },
+        qr/is not ArrayRef\[HashRef\[Any\]\]/,
+        "string is not correct"
+    );
+
+};