New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qiangliu/dzil for locale #11

Merged
merged 15 commits into from Jan 10, 2019

Conversation

Projects
None yet
5 participants
@nooneisthere
Copy link

nooneisthere commented Jan 7, 2019

No description provided.

liu added some commits Jan 7, 2019

liu
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          53     53           
  Branches        5      5           
=====================================
  Hits           53     53
Impacted Files Coverage Δ
lib/Locale/Country/Extra.pm 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4585d86...6577a1f. Read the comment docs.

Show resolved Hide resolved .travis.yml Outdated
.travis.yml Outdated
- '5.20'
- '5.18'
- '5.16'
- '5.14'

This comment has been minimized.

@zakame

zakame Jan 7, 2019

I'd recommend updating to

perl:
   - "5.28"
   - "5.26"
   - "5.24"
   - "5.14"

As the last one is the earliest we can care to support, while the latest 3 are currently supported per https://metacpan.org/pod/perlpolicy#MAINTENANCE-AND-SUPPORT

This comment has been minimized.

@nooneisthere

This comment has been minimized.

@nooneisthere

nooneisthere Jan 7, 2019

I updated it ,seems traivs fail on 5.28

This comment has been minimized.

@nooneisthere

nooneisthere Jan 7, 2019

t/00-compile.t ......... 1/2 Locale::Country will be removed from the Perl core distribution in the next major release
Locale::Codes will be removed from the Perl core distribution in the next major release.

we got those waring for use perl 5.28, should we remove 5.28?

cpanfile Outdated
@@ -0,0 +1,13 @@
requires 'Locale::Country';
requires 'Locale::Country::Multilingual';
requires 'perl', '5.006';

This comment has been minimized.

@zakame

zakame Jan 7, 2019

I think perl >= 5.6 is implied, could be dropped here

cpanfile Outdated
requires 'perl', '5.006';

on configure => sub {
requires 'ExtUtils::MakeMaker';

This comment has been minimized.

@zakame

zakame Jan 7, 2019

Would be useful here if we're depending on a specific minimum MakeMaker version; otherwise this can be dropped

This comment has been minimized.

@nooneisthere

nooneisthere Jan 7, 2019

this cpanfile is generated auto by mymeta-cpanfile > cpanfile
should we change it manually?

This comment has been minimized.

@zakame

zakame Jan 7, 2019

Yes, mymeta-cpanfile is a transition tool mostly, maintainers should be updating cpanfile directly.

This comment has been minimized.

@nooneisthere
cpanfile Outdated
requires 'ExtUtils::MakeMaker';
};

on build => sub {

This comment has been minimized.

@zakame

zakame Jan 7, 2019

Suggested change Beta
on build => sub {
on test => sub {

This comment has been minimized.

@chylli

chylli Jan 7, 2019

Contributor
Locale::Codes will be removed from the Perl core distribution in the next major release. Please install it from CPAN. It is being used at /home/travis/perl5/perlbrew/perls/5.28.1/lib/5.28.1/Locale/Country.pm, line 22.```
So I guess we need to add Local::Country into cpanfile and install it by cpm if necessary. 

liu added some commits Jan 7, 2019

liu
liu
liu
liu
liu
liu
liu
liu
liu

@jy-binary jy-binary merged commit 7caa6ce into binary-com:master Jan 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment