New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qiangliu/mt5 countries mismatch #13

Merged
merged 45 commits into from Feb 19, 2019

Conversation

Projects
None yet
5 participants
@nooneisthere
Copy link
Contributor

nooneisthere commented Feb 3, 2019

No description provided.

liu added some commits Jan 9, 2019

@nooneisthere nooneisthere reopened this Feb 8, 2019

liu
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 8, 2019

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          58     56    -2     
  Branches        7      7           
=====================================
- Hits           58     56    -2
Impacted Files Coverage Δ
lib/Locale/Country/Extra.pm 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ede604...6e17e4a. Read the comment docs.

Show resolved Hide resolved lib/Locale/Country/Extra.pm Outdated

liu added some commits Feb 11, 2019

liu
liu
liu
liu
Show resolved Hide resolved Changes Outdated
liu
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved lib/Locale/Country/Extra.pm Outdated
README.md Outdated
@@ -17,6 +17,29 @@ my $idd = $countries->idd_from_code('in'); # returns 91
my $code = $countries->code_from_phone('+44 8882220202'); # returns 'gb'
```

Extra alias coutry names supported for code_from_country

This comment has been minimized.

@code4pay

code4pay Feb 14, 2019

I know this is not your original documentation but it doesn't really seem to spell out what this module is for and its connection to Locale::Country::Multilingual

This comment has been minimized.

@nooneisthere

nooneisthere Feb 15, 2019

Author Contributor

I am not sure your meaning here...
maybe we can have a serperated card for the document things

"syrian arab republic" => "sy",
"u.a.e." => "ae",
"vatican city state" => "va",
"virgin islands" => "vg"

This comment has been minimized.

This comment has been minimized.

@nooneisthere

liu added some commits Feb 14, 2019

liu
liu
liu
liu
liu
liu
liu

@raunakkathuria raunakkathuria merged commit 4ad7598 into binary-com:master Feb 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment