New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: prefer `cover -test` over setting PERL5OPT #4

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@zakame
Contributor

zakame commented Oct 5, 2018

Using PERL5OPT can lead to unintentional failures when forking (especially across different Perl versions in corner cases.) Use the standard cover -test command instead, which is already provided by Devel::Cover.

.travis.yml: prefer `cover -test` over setting PERL5OPT
Using `PERL5OPT` can lead to unintentional failures when
forking (especially across different Perl versions in corner cases.)
Use the standard `cover -test` command instead, which is already
provided by Devel::Cover.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 5, 2018

Codecov Report

Merging #4 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   93.45%   93.37%   -0.08%     
==========================================
  Files           4        3       -1     
  Lines         168      166       -2     
  Branches       28       28              
==========================================
- Hits          157      155       -2     
  Misses          2        2              
  Partials        9        9
Impacted Files Coverage Δ
Build

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88214b0...9efac8a. Read the comment docs.

codecov-io commented Oct 5, 2018

Codecov Report

Merging #4 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   93.45%   93.37%   -0.08%     
==========================================
  Files           4        3       -1     
  Lines         168      166       -2     
  Branches       28       28              
==========================================
- Hits          157      155       -2     
  Misses          2        2              
  Partials        9        9
Impacted Files Coverage Δ
Build

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88214b0...9efac8a. Read the comment docs.

@binarytom binarytom merged commit eb6ebaf into binary-com:master Oct 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment