New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBIx::Migration::psql(): Use File::Temp OO form #4

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@zakame

zakame commented Oct 2, 2018

Avoid using undef as a template for tempfile() and instead use the primary (OO) interface of File::Temp (we can get the filename later through a method.)

DBIx::Migration::psql(): Use File::Temp OO form
Avoid using `undef` as a template for `tempfile()` and instead use the
primary (OO) interface of File::Temp (we can get the filename later
through a method.)
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 2, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@1494a16). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master    #4   +/-   ##
======================================
  Coverage          ?   50%           
======================================
  Files             ?     1           
  Lines             ?   142           
  Branches          ?    41           
======================================
  Hits              ?    71           
  Misses            ?    56           
  Partials          ?    15
Impacted Files Coverage Δ
lib/DBIx/Migration.pm 50% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1494a16...042e954. Read the comment docs.

codecov-io commented Oct 2, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@1494a16). Click here to learn what that means.
The diff coverage is 33.33%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master    #4   +/-   ##
======================================
  Coverage          ?   50%           
======================================
  Files             ?     1           
  Lines             ?   142           
  Branches          ?    41           
======================================
  Hits              ?    71           
  Misses            ?    56           
  Partials          ?    15
Impacted Files Coverage Δ
lib/DBIx/Migration.pm 50% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1494a16...042e954. Read the comment docs.

@jy-binary jy-binary merged commit f6a8b5b into binary-com:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zakame zakame deleted the zakame:zakame/dbix_migration_tempfile branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment