New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBIx::Migration::psql(): clear PERL5* vars before /usr/bin/psql #5

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
5 participants
@zakame

zakame commented Oct 11, 2018

Avoid having PERL5OPT and PERL5LIB in the environment prior to running /usr/bin/psql, as in Debian's case, the command is actually a Perl wrapper to determine the latest available version (in the case of multiple installed PostgreSQL versions.)

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 11, 2018

Codecov Report

Merging #5 into master will decrease coverage by 0.34%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage      50%   49.65%   -0.35%     
==========================================
  Files           1        1              
  Lines         142      143       +1     
  Branches       41       41              
==========================================
  Hits           71       71              
- Misses         56       57       +1     
  Partials       15       15
Impacted Files Coverage Δ
lib/DBIx/Migration.pm 49.65% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a8b5b...b860d32. Read the comment docs.

codecov-io commented Oct 11, 2018

Codecov Report

Merging #5 into master will decrease coverage by 0.34%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage      50%   49.65%   -0.35%     
==========================================
  Files           1        1              
  Lines         142      143       +1     
  Branches       41       41              
==========================================
  Hits           71       71              
- Misses         56       57       +1     
  Partials       15       15
Impacted Files Coverage Δ
lib/DBIx/Migration.pm 49.65% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a8b5b...b860d32. Read the comment docs.

Show outdated Hide outdated lib/DBIx/Migration.pm Outdated
DBIx::Migration::psql(): clear PERL5* vars before /usr/bin/psql
Avoid having `PERL5OPT` and `PERL5LIB` in the environment prior to
running `/usr/bin/psql`, as in Debian's case, the command is actually a
Perl wrapper to determine the latest available version (in the case of
multiple installed PostgreSQL versions.)

@jy-binary jy-binary merged commit 4838e8a into binary-com:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment