Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed bug using BinaryJS between two servers. #34

Merged
merged 1 commit into from

2 participants

@Ifnot

Adding the missing first parameter used by BinaryClient for new instance
creation.

@Ifnot Ifnot Fix missing first parameter for BinaryClient
Adding the missing first parameter used by BinaryClient for new instance
creation.
282f356
@ericz
Owner

Good call!

@ericz ericz merged commit ebaa89f into binaryjs:master

1 check passed

Details default The Travis build passed
@Ifnot

Hey, is it possible for you to bump the version in npm ?

I have to distribute my app depending of binaryjs and without the fix #34 it will not work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 15, 2013
  1. @Ifnot

    Fix missing first parameter for BinaryClient

    Ifnot authored
    Adding the missing first parameter used by BinaryClient for new instance
    creation.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/client.js
View
2  lib/client.js
@@ -10,7 +10,7 @@ var BinaryStream = require('./stream').BinaryStream;
// end node
function BinaryClient(socket, options) {
- if (!(this instanceof BinaryClient)) return new BinaryClient(options);
+ if (!(this instanceof BinaryClient)) return new BinaryClient(socket, options);
EventEmitter.call(this);
Something went wrong with that request. Please try again.