email regexp matches with newline, but shouldn't #95

Closed
e2 opened this Issue Jan 31, 2010 · 3 comments

Comments

Projects
None yet
3 participants
@e2

e2 commented Jan 31, 2010

Although probably affects no one except me, the email regexp should use '\z' instead of '$' (match end of string instead of end of line).

BTW, thanks for Authlogic!

@boone

This comment has been minimized.

Show comment Hide comment
@boone

boone Feb 1, 2010

Contributor

Good call. According to the Rails security guide, regexes typically should start/end with \A and \z instead of ^ and $:

http://guides.rubyonrails.org/security.html#regular-expressions

Contributor

boone commented Feb 1, 2010

Good call. According to the Rails security guide, regexes typically should start/end with \A and \z instead of ^ and $:

http://guides.rubyonrails.org/security.html#regular-expressions

@boone

This comment has been minimized.

Show comment Hide comment
@tiegz

This comment has been minimized.

Show comment Hide comment
@tiegz

tiegz Sep 12, 2014

Collaborator

(fixed in 5eaa0f3)

Collaborator

tiegz commented Sep 12, 2014

(fixed in 5eaa0f3)

@tiegz tiegz closed this Sep 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment