Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
email regexp matches with newline, but shouldn't #95
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
boone
Feb 1, 2010
Contributor
Good call. According to the Rails security guide, regexes typically should start/end with \A and \z instead of ^ and $:
http://guides.rubyonrails.org/security.html#regular-expressions
Good call. According to the Rails security guide, regexes typically should start/end with \A and \z instead of ^ and $: http://guides.rubyonrails.org/security.html#regular-expressions |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
boone
Feb 1, 2010
Contributor
I fixed this in my fork:
http://github.com/boone/authlogic/commit/6870d194448945f7252b2ce228b73576a7545807
I fixed this in my fork: |
(fixed in 5eaa0f3) |
tiegz
closed this
Sep 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
e2 commentedJan 31, 2010
Although probably affects no one except me, the email regexp should use '\z' instead of '$' (match end of string instead of end of line).
BTW, thanks for Authlogic!