Fixing Authlogic::Session::Callbacks for rails 3 #285

Merged
4 commits merged into from Oct 18, 2011

1 participant

@tiegz
Collaborator

I noticed this week that in 3.0.3 of Authlogic (w/Rails 3), the whole "persist" callback chain is run thru always, ignoring the callbacks that should halt the chain (someone also reported this a year ago: #194).

This patch implements CallbacksTest in Authlogic and ensures that persistence callbacks that return true will halt the persist callback chain.

tiegz added some commits Oct 17, 2011
@tiegz tiegz Fixing Authlogic::Session::Callbacks for new rails 3 callback system …
…(the run_callback block serves different purpose).

Also fixes an http_auth test that wasn't caught b/c of the callback bug (reset the persisted session when testing http auth multiple times).
7628fa5
@tiegz tiegz Minor fixes for Callbacks fix patch da4f628
@tiegz tiegz removing previous cleanup (the splat seems to cause an error in REE/P…
…assenger)
579e62b
@tiegz tiegz final fix for define_callback argument issues (passing a hash at end …
…of args array)
e87e72c
@ghost ghost merged commit c7631c1 into binarylogic:master Oct 18, 2011
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment