Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fixes issues #260 #295

Merged
1 commit merged into from

4 participants

@stephenprater

Trying to rw_config a nil value where the default_value is also nil ( for instance, using omniauth and not using "login" or "password" credentials) will give raise a Stack Too Deep exception.

Patch simply checks if the default_value is nil, and if so leaves the key empty in config (which will return nil anyway.)

@parkr

+1 +1 +1

@ghost ghost merged commit c2c5c98 into binarylogic:master
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 29, 2011
  1. @stephenprater

    fixes issues #260

    stephenprater authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/authlogic/session/foundation.rb
View
4 lib/authlogic/session/foundation.rb
@@ -19,7 +19,7 @@ module ClassMethods
def rw_config(key, value, default_value = nil, read_value = nil)
if value == read_value
return acts_as_authentic_config[key] if acts_as_authentic_config.include?(key)
- rw_config(key, default_value)
+ rw_config(key, default_value) unless default_value.nil?
else
config = acts_as_authentic_config.clone
config[key] = value
@@ -74,4 +74,4 @@ def build_key(last_part)
end
end
end
-end
+end
Something went wrong with that request. Please try again.