Make the gemspec compatible with JRuby and enable spec runs under JRuby #399

Merged
merged 2 commits into from Apr 29, 2014

Projects

None yet

4 participants

@petergoldstein
  1. Removed sqlite3 from the gemspec
  2. Added sqlite3 and activerecord-jdbcsqlite3-adapter with appropriate platform directives to each of the gemfiles.

Specs now run under JRuby, although they fail for the reasons discussed in issue #393

Specs don't run under 1.8.7 and ree, which is the case in current master - https://travis-ci.org/petergoldstein/authlogic/builds/19884461

@nathany

@yourewelcome This looks good to me.

@binarylogic
Owner

I like this, but how why is jruby the default for rails 4?

@petergoldstein

@yourewelcome I'm not sure what you mean. JRuby is not the default, as there's no lockfile checked in.

@nathany

While we're at it, might as well update activerecord/activesupport to 4.0.4 and 4.1.0 final.

@petergoldstein

@nathany Sure. Done.

On another note, I'm seeing spec failures on this branch after rebasing. Everything passing for Rails 4.1, but earlier versions of rails now fail. These same failures also appear on master, so the code in this branch doesn't seem to be the issue

@nathany

Hopefully that won't occur in the future, as I understand @yourewelcome is getting Travis.ci setup against pull requests #374.

@binarylogic binarylogic merged commit 69b269c into binarylogic:master Apr 29, 2014
@petergoldstein

@nathany I found the failure - it was introduced with this commit - 524358e

I fixed the issue and everything runs green now. I also moved Rails 4.1.0 out of allowed failures and removed 1.8.7 and ree because they conflicted with scrypt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment